Files
OmniRoute/tests/unit/combo-empty-models.test.ts
Diego Rodrigues de Sa e Souza 93265eede3 test(infra): retry recursive temp-dir removal on main (main twin of #11968) (#12246)
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)

`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.

* chore(scripts): carry the rm-maxretries codemod onto main alongside its output

The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
2026-09-01 01:48:00 -03:00

60 lines
2.2 KiB
TypeScript

import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import assert from "node:assert/strict";
import test from "node:test";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-combo-empty-models-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const { createComboSchema, updateComboSchema } =
await import("../../src/shared/validation/schemas/combo.ts");
const { getCopilotTool } = await import("../../src/lib/copilot/tools.ts");
const combosDb = await import("../../src/lib/db/combos.ts");
const core = await import("../../src/lib/db/core.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("an update cannot remove every model from a combo", () => {
assert.equal(updateComboSchema.safeParse({ models: [] }).success, false);
assert.equal(updateComboSchema.safeParse({ models: ["openai/gpt-4o-mini"] }).success, true);
assert.equal(updateComboSchema.safeParse({ name: "renamed" }).success, true);
});
test("creating a combo without a model is refused at the boundary", () => {
assert.equal(createComboSchema.safeParse({ name: "drafted", models: [] }).success, false);
assert.equal(createComboSchema.safeParse({ name: "drafted" }).success, false);
});
test("the copilot createCombo tool stores targets where the router looks for them", async () => {
const tool = getCopilotTool("createCombo");
assert.ok(tool);
await tool.handler({
name: "copilot-stored",
strategy: "priority",
targets: JSON.stringify([{ provider: "openai", model: "gpt-4o-mini", weight: 100 }]),
});
const stored = (await combosDb.getComboByName("copilot-stored")) as { models?: unknown[] } | null;
assert.ok(stored, "the combo should exist");
assert.equal(stored.models?.length, 1);
});
test("the copilot combo list counts the targets the router will use", async () => {
const list = getCopilotTool("listCombos");
assert.ok(list);
await combosDb.createCombo({
name: "dashboard-made",
strategy: "priority",
models: ["openai/gpt-4o-mini", "openai/gpt-4o"],
});
const output = await list.handler({});
assert.match(output, /\*\*dashboard-made\*\* — strategy: `priority` — 2 target\(s\)/);
});