Files
OmniRoute/tests/unit/combo-prescreen.test.ts
Diego Rodrigues de Sa e Souza 93265eede3 test(infra): retry recursive temp-dir removal on main (main twin of #11968) (#12246)
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)

`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.

* chore(scripts): carry the rm-maxretries codemod onto main alongside its output

The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
2026-09-01 01:48:00 -03:00

244 lines
6.6 KiB
TypeScript

import test, { after } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-combo-prescreen-"));
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
process.env.DATA_DIR = TEST_DATA_DIR;
const dbCore = await import("../../src/lib/db/core.ts");
const { handleComboChat } = await import("../../open-sse/services/combo.ts");
const combosDb = await import("../../src/lib/db/combos.ts");
after(() => {
dbCore.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
if (ORIGINAL_DATA_DIR === undefined) {
delete process.env.DATA_DIR;
} else {
process.env.DATA_DIR = ORIGINAL_DATA_DIR;
}
});
function okResponse(model: string) {
return Response.json({ choices: [{ message: { role: "assistant", content: model } }] });
}
function makeLog() {
return {
info() {},
warn() {},
debug() {},
error() {},
};
}
const reqBody = {
model: "prescreen-test",
messages: [{ role: "user", content: "hi" }],
stream: false,
};
test("pre-screen: all targets checked in parallel", async () => {
const checkOrder: string[] = [];
const combo = await combosDb.createCombo({
name: "prescreen-parallel",
strategy: "priority",
models: ["p1/m1", "p2/m2", "p3/m3"],
});
const response = await handleComboChat({
body: { ...reqBody, model: combo.name },
combo,
allCombos: [combo],
isModelAvailable: async (modelStr: string) => {
checkOrder.push(modelStr);
return true;
},
relayOptions: undefined,
signal: undefined,
settings: {},
log: makeLog(),
handleSingleModel: async (_body: unknown, modelStr: string) => {
return okResponse(modelStr);
},
});
assert.equal(response.status, 200);
assert.ok(checkOrder.length >= 3, "pre-screen must check all 3 targets concurrently");
});
test("pre-screen: unavailable targets are skipped", async () => {
const calls: string[] = [];
const availability = new Map([
["p1/m1", false],
["p2/m2", true],
["p3/m3", true],
]);
const combo = await combosDb.createCombo({
name: "prescreen-skip",
strategy: "priority",
models: ["p1/m1", "p2/m2", "p3/m3"],
});
const response = await handleComboChat({
body: { ...reqBody, model: combo.name },
combo,
allCombos: [combo],
isModelAvailable: async (modelStr: string) => {
return availability.get(modelStr) ?? true;
},
relayOptions: undefined,
signal: undefined,
settings: {},
log: makeLog(),
handleSingleModel: async (_body: unknown, modelStr: string) => {
calls.push(modelStr);
return okResponse(modelStr);
},
});
assert.equal(response.status, 200);
assert.equal(calls.length, 1);
assert.equal(calls[0], "p2/m2");
});
test("pre-screen: failure treated as unknown availability", async () => {
const calls: string[] = [];
let checkCount = 0;
const combo = await combosDb.createCombo({
name: "prescreen-failure",
strategy: "priority",
models: ["p1/m1", "p2/m2"],
});
const response = await handleComboChat({
body: { ...reqBody, model: combo.name },
combo,
allCombos: [combo],
isModelAvailable: async (modelStr: string) => {
checkCount++;
if (checkCount === 1) {
throw new Error("DB connection failed");
}
return true;
},
relayOptions: undefined,
signal: undefined,
settings: {},
log: makeLog(),
handleSingleModel: async (_body: unknown, modelStr: string) => {
calls.push(modelStr);
return okResponse(modelStr);
},
});
assert.equal(response.status, 200);
// m1 pre-screen failed (treated as available), m2 pre-screen succeeded
// Both should be tried, m1 first since it's available
assert.equal(calls.length, 1);
assert.equal(calls[0], "p1/m1");
});
test("pre-screen: only runs for priority strategy", async () => {
const checkOrder: string[] = [];
const combo = await combosDb.createCombo({
name: "prescreen-strategy",
strategy: "round-robin",
models: ["p1/m1", "p2/m2"],
});
const response = await handleComboChat({
body: { ...reqBody, model: combo.name },
combo,
allCombos: [combo],
isModelAvailable: async (modelStr: string) => {
checkOrder.push(modelStr);
return true;
},
relayOptions: undefined,
signal: undefined,
settings: {},
log: makeLog(),
handleSingleModel: async (_body: unknown, modelStr: string) => {
return okResponse(modelStr);
},
});
assert.equal(response.status, 200);
assert.equal(checkOrder.length >= 1, true);
});
test("pre-screen: backward compatible with all targets available", async () => {
const calls: string[] = [];
const combo = await combosDb.createCombo({
name: "prescreen-compat",
strategy: "priority",
models: ["p1/m1", "p2/m2", "p3/m3"],
});
const response = await handleComboChat({
body: { ...reqBody, model: combo.name },
combo,
allCombos: [combo],
isModelAvailable: async () => true,
relayOptions: undefined,
signal: undefined,
settings: {},
log: makeLog(),
handleSingleModel: async (_body: unknown, modelStr: string) => {
calls.push(modelStr);
return okResponse(modelStr);
},
});
assert.equal(response.status, 200);
assert.equal(calls.length, 1);
assert.equal(calls[0], "p1/m1");
});
test("priority combo: quota 429 on passthrough provider does not skip another model on same provider", async () => {
const calls: string[] = [];
const combo = await combosDb.createCombo({
name: "passthrough-quota-scope",
strategy: "priority",
models: ["antigravity/claude-opus-4-6-thinking", "antigravity/gemini-3.7-flash-high"],
});
const response = await handleComboChat({
body: { ...reqBody, model: combo.name },
combo,
allCombos: [combo],
isModelAvailable: async () => true,
relayOptions: undefined,
signal: undefined,
settings: {},
log: makeLog(),
handleSingleModel: async (_body: unknown, modelStr: string) => {
calls.push(modelStr);
if (modelStr.includes("claude-opus")) {
return Response.json(
{ error: { message: "quota exhausted for claude-opus-4-6-thinking" } },
{ status: 429 }
);
}
return okResponse(modelStr);
},
});
assert.equal(response.status, 200);
assert.equal(calls.at(-1), "antigravity/gemini-3.7-flash-high");
assert.ok(
calls.includes("antigravity/claude-opus-4-6-thinking"),
"first passthrough model should be attempted before fallback"
);
});