Files
OmniRoute/tests/unit/custom-model-target-format.test.ts
Diego Rodrigues de Sa e Souza 93265eede3 test(infra): retry recursive temp-dir removal on main (main twin of #11968) (#12246)
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)

`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.

* chore(scripts): carry the rm-maxretries codemod onto main alongside its output

The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
2026-09-01 01:48:00 -03:00

84 lines
3.0 KiB
TypeScript

/**
* Issue #2905 — custom models (added via the UI) on opencode-go / openai-compatible
* nodes always routed as OpenAI-compatible because there was no way to set a
* per-model `targetFormat`. `addCustomModel` didn't accept it, the API schema
* stripped it, and routing (`getModelTargetFormat`, static-registry-only) never
* saw it — so a custom model that needs the Anthropic Messages shape fell back
* to the provider default ("openai").
*
* This test verifies the persistence + getModelInfo-injection chain: a custom
* model saved with targetFormat: "claude" is surfaced on the resolved modelInfo
* (which chatCore then uses before the provider default).
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-custom-target-format-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const modelsDb = await import("../../src/lib/db/models.ts");
const { getModelInfo } = await import("../../src/sse/services/model.ts");
test.before(async () => {
await providersDb.createProviderNode({
id: "openai-compatible-2905",
type: "openai-compatible",
name: "Gateway 2905",
prefix: "g29",
baseUrl: "https://proxy.example.com",
chatPath: "/v1/chat/completions",
modelsPath: "/v1/models",
});
});
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("#2905 addCustomModel persists targetFormat", async () => {
await modelsDb.addCustomModel(
"openai-compatible-2905",
"my-claude-model",
"My Claude Model",
"manual",
"chat-completions",
["chat"],
"claude"
);
const models = (await modelsDb.getCustomModels("openai-compatible-2905")) as Array<{
id: string;
targetFormat?: string;
}>;
const saved = models.find((m) => m.id === "my-claude-model");
assert.ok(saved, "custom model must be saved");
assert.equal(saved.targetFormat, "claude", "targetFormat must be persisted");
});
test("#2905 getModelInfo surfaces the custom model targetFormat", async () => {
const info = (await getModelInfo("g29/my-claude-model")) as {
provider?: string;
targetFormat?: string;
};
assert.equal(info.provider, "openai-compatible-2905", "must resolve to the custom node");
assert.equal(info.targetFormat, "claude", "getModelInfo must inject the custom targetFormat");
});
test("#2905 a custom model without targetFormat surfaces none (provider default applies)", async () => {
await modelsDb.addCustomModel(
"openai-compatible-2905",
"plain-model",
"Plain Model",
"manual",
"chat-completions",
["chat"]
);
const info = (await getModelInfo("g29/plain-model")) as { targetFormat?: string };
assert.equal(info.targetFormat, undefined, "no targetFormat → falls back to provider default");
});