mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-15 03:12:36 +03:00
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)
`main` has been red since b342c1a361 on the vitest and integration gates:
✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos
Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).
release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.
This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.
The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.
* chore(scripts): carry the rm-maxretries codemod onto main alongside its output
The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
116 lines
4.5 KiB
TypeScript
116 lines
4.5 KiB
TypeScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { mkdtempSync, mkdirSync, writeFileSync, existsSync, readdirSync, rmSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
|
|
import { fixTlsClientNodeBinary } from "../../scripts/build/fixTlsClientNodeBinary.mjs";
|
|
|
|
function makeRoot() {
|
|
return mkdtempSync(join(tmpdir(), "fix-tls-client-node-binary-7802-"));
|
|
}
|
|
|
|
function collectLogs() {
|
|
const logs: string[] = [];
|
|
return { logs, log: (m: string) => logs.push(m) };
|
|
}
|
|
|
|
test("no-ops when node_modules/tls-client-node is absent (module not installed)", async () => {
|
|
const rootDir = makeRoot();
|
|
try {
|
|
const { logs, log } = collectLogs();
|
|
await fixTlsClientNodeBinary({ rootDir, log });
|
|
assert.deepEqual(logs, []);
|
|
} finally {
|
|
rmSync(rootDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("copies an already-populated root bin/ into the standalone dist bundle (#7802 item 2)", async () => {
|
|
const rootDir = makeRoot();
|
|
try {
|
|
const rootBin = join(rootDir, "node_modules", "tls-client-node", "bin");
|
|
mkdirSync(rootBin, { recursive: true });
|
|
writeFileSync(join(rootBin, "tls-client-linux-ubuntu-amd64-1.0.0.so"), "fake-binary");
|
|
|
|
const distTlsClientDir = join(rootDir, "dist", "node_modules", "tls-client-node");
|
|
mkdirSync(distTlsClientDir, { recursive: true });
|
|
|
|
const { log } = collectLogs();
|
|
await fixTlsClientNodeBinary({ rootDir, log });
|
|
|
|
const distBin = join(distTlsClientDir, "bin");
|
|
assert.ok(existsSync(distBin), "dist bin/ should have been created");
|
|
assert.deepEqual(readdirSync(distBin), ["tls-client-linux-ubuntu-amd64-1.0.0.so"]);
|
|
} finally {
|
|
rmSync(rootDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("retries the download when root bin/ is empty, and stops once a file appears (#7802 item 3)", async () => {
|
|
const rootDir = makeRoot();
|
|
try {
|
|
const tlsClientDir = join(rootDir, "node_modules", "tls-client-node");
|
|
const rootBin = join(tlsClientDir, "bin");
|
|
mkdirSync(rootBin, { recursive: true });
|
|
|
|
const scriptsDir = join(tlsClientDir, "scripts");
|
|
mkdirSync(scriptsDir, { recursive: true });
|
|
// A postinstall.js stand-in that drops a file into bin/ on its 2nd invocation —
|
|
// simulating a first attempt eaten by a GitHub rate-limit and a 2nd that recovers.
|
|
writeFileSync(
|
|
join(scriptsDir, "postinstall.js"),
|
|
`const fs = require("fs");
|
|
const path = require("path");
|
|
const marker = path.join(__dirname, "..", ".attempts");
|
|
const attempts = fs.existsSync(marker) ? Number(fs.readFileSync(marker, "utf8")) : 0;
|
|
fs.writeFileSync(marker, String(attempts + 1));
|
|
if (attempts + 1 >= 2) {
|
|
fs.writeFileSync(path.join(__dirname, "..", "bin", "tls-client-linux-ubuntu-amd64-1.0.0.so"), "ok");
|
|
}`
|
|
);
|
|
|
|
const { logs, log } = collectLogs();
|
|
await fixTlsClientNodeBinary({ rootDir, log, retryDelaysMs: [1, 1, 1] });
|
|
|
|
assert.ok(existsSync(join(rootBin, "tls-client-linux-ubuntu-amd64-1.0.0.so")));
|
|
assert.ok(
|
|
logs.some((m) => m.includes("fetched successfully")),
|
|
"expected a success log once the retry recovered"
|
|
);
|
|
} finally {
|
|
rmSync(rootDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("warns without throwing when every retry leaves bin/ empty (still rate-limited)", async () => {
|
|
const rootDir = makeRoot();
|
|
try {
|
|
const tlsClientDir = join(rootDir, "node_modules", "tls-client-node");
|
|
mkdirSync(join(tlsClientDir, "bin"), { recursive: true });
|
|
const scriptsDir = join(tlsClientDir, "scripts");
|
|
mkdirSync(scriptsDir, { recursive: true });
|
|
// A postinstall.js stand-in that always fails to produce a binary (persistent rate-limit).
|
|
writeFileSync(join(scriptsDir, "postinstall.js"), `process.exitCode = 0;`);
|
|
|
|
const originalWarn = console.warn;
|
|
const warnings: string[] = [];
|
|
console.warn = (m: string) => warnings.push(m);
|
|
try {
|
|
const { log } = collectLogs();
|
|
await assert.doesNotReject(
|
|
fixTlsClientNodeBinary({ rootDir, log, retryDelaysMs: [1, 1] })
|
|
);
|
|
} finally {
|
|
console.warn = originalWarn;
|
|
}
|
|
|
|
assert.ok(
|
|
warnings.some((m) => m.includes("Could not fetch tls-client-node")),
|
|
"expected a clear warning pointing at the manual fix, not a silent no-op"
|
|
);
|
|
} finally {
|
|
rmSync(rootDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|