mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-15 03:12:36 +03:00
93265eede3
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)
`main` has been red since b342c1a361 on the vitest and integration gates:
✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos
Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).
release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.
This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.
The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.
* chore(scripts): carry the rm-maxretries codemod onto main alongside its output
The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
66 lines
2.5 KiB
TypeScript
66 lines
2.5 KiB
TypeScript
// Regression guard: POST /api/models/test must always return a STRING `error`,
|
|
// never an object. The Zod-validation and invalid-JSON paths used to return
|
|
// `{ error: <object> }` (Zod .format() / a details object). The dashboard renders
|
|
// that value directly in a toast, so an object froze the whole page (React #31).
|
|
// The "test a model → screen froze" bug.
|
|
//
|
|
// DB handles released in test.after (CLAUDE.md learning: unreleased SQLite
|
|
// handles hang node:test).
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-models-test-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const settingsDb = await import("../../src/lib/db/settings.ts");
|
|
const route = await import("../../src/app/api/models/test/route.ts");
|
|
|
|
test.before(async () => {
|
|
await settingsDb.updateSettings({ requireLogin: false });
|
|
});
|
|
|
|
test.after(async () => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
function post(body: unknown, rawText?: string) {
|
|
return route.POST(
|
|
new Request("http://localhost:20128/api/models/test", {
|
|
method: "POST",
|
|
headers: { "Content-Type": "application/json" },
|
|
body: rawText !== undefined ? rawText : JSON.stringify(body),
|
|
})
|
|
);
|
|
}
|
|
|
|
test("Zod validation failure returns a STRING error (not an object)", async () => {
|
|
// connectionId "" fails z.string().min(1).optional() -> validation error path
|
|
const res = await post({ providerId: "openai", modelId: "gpt-4o", connectionId: "" });
|
|
assert.equal(res.status, 400);
|
|
const body = await res.json();
|
|
assert.equal(typeof body.error, "string", "error must be a string, never an object");
|
|
assert.equal(body.status, "error");
|
|
assert.match(body.error, /Invalid request/i);
|
|
});
|
|
|
|
test("missing required field returns a STRING error", async () => {
|
|
const res = await post({ providerId: "openai" }); // no modelId
|
|
assert.equal(res.status, 400);
|
|
const body = await res.json();
|
|
assert.equal(typeof body.error, "string");
|
|
});
|
|
|
|
test("invalid JSON body returns a STRING error (not an object)", async () => {
|
|
const res = await post(undefined, "{ not json ");
|
|
assert.equal(res.status, 400);
|
|
const body = await res.json();
|
|
assert.equal(typeof body.error, "string");
|
|
assert.match(body.error, /Invalid JSON/i);
|
|
});
|