Files
OmniRoute/tests/unit/rate-limit-queue-timeout-lockout.test.ts
Diego Rodrigues de Sa e Souza 93265eede3 test(infra): retry recursive temp-dir removal on main (main twin of #11968) (#12246)
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)

`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.

* chore(scripts): carry the rm-maxretries codemod onto main alongside its output

The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
2026-09-01 01:48:00 -03:00

141 lines
4.3 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omr-rl-queue-timeout-lockout-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = "test-rl-lockout-secret";
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const { handleComboChat } = await import("../../open-sse/services/combo.ts");
const { getModelLockoutInfo, isModelLocked } =
await import("../../open-sse/services/accountFallback.ts");
function createLog() {
return {
info: () => {},
warn: () => {},
error: () => {},
debug: () => {},
};
}
async function seedConnection(provider: string, overrides: any = {}): Promise<any> {
return providersDb.createProviderConnection({
provider,
authType: "apikey",
name: overrides.name || `${provider}-${Math.random().toString(16).slice(2, 8)}`,
apiKey: overrides.apiKey || `sk-test-${Math.random().toString(16).slice(2, 8)}`,
isActive: true,
testStatus: "active",
rateLimitedUntil: null,
backoffLevel: overrides.backoffLevel || 0,
providerSpecificData: overrides.providerSpecificData || {},
});
}
function errorResponseWithoutConnectionId(status: number) {
return new Response(JSON.stringify({ error: { message: "Local queue timeout" } }), {
status,
headers: { "content-type": "application/json" },
});
}
function errorResponseWithConnectionId(status: number, connectionId: string) {
return new Response(JSON.stringify({ error: { message: "Local queue timeout" } }), {
status,
headers: {
"content-type": "application/json",
"X-OmniRoute-Selected-Connection-Id": connectionId,
},
});
}
test.afterEach(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("RATE_LIMIT_QUEUE_TIMEOUT lockout behaves correctly depending on connection ID header", async () => {
const provider = "openai";
const model = "gpt-4";
// Seed the connection first!
const connection = await seedConnection(provider);
const connectionId = connection.id;
const customSettings = {
modelLockout: {
enabled: true,
errorCodes: [502, 520],
baseCooldownMs: 3000,
maxCooldownMs: 5000,
maxBackoffSteps: 10,
useExponentialBackoff: true,
},
};
const logs = createLog();
// Scenario 1: Response lacks connection ID header (Current buggy behavior)
await handleComboChat({
body: {},
combo: {
name: "test-combo",
strategy: "priority",
models: [`${provider}/${model}`],
config: { maxRetries: 0, retryDelayMs: 0, fallbackDelayMs: 0 },
},
handleSingleModel: async () => {
return errorResponseWithoutConnectionId(502);
},
isModelAvailable: async () => true,
log: logs as any,
settings: customSettings,
allCombos: null,
});
// Verify that the model is NOT locked for the actual connection connectionId
const lockedForConnBuggy = isModelLocked(provider, connectionId, model);
assert.equal(
lockedForConnBuggy,
false,
"Model should not be locked for actual connection when header is missing"
);
// Verify that it got locked under the empty string connectionId ""
const lockedForEmptyBuggy = isModelLocked(provider, "", model);
assert.equal(
lockedForEmptyBuggy,
true,
"Model is incorrectly locked under empty string connectionId when header is missing"
);
const { clearAllModelLockouts } = await import("../../open-sse/services/accountFallback.ts");
clearAllModelLockouts();
await handleComboChat({
body: {},
combo: {
name: "test-combo",
strategy: "priority",
models: [`${provider}/${model}`],
config: { maxRetries: 0, retryDelayMs: 0, fallbackDelayMs: 0 },
},
handleSingleModel: async () => {
return errorResponseWithConnectionId(502, connectionId);
},
isModelAvailable: async () => true,
log: logs as any,
settings: customSettings,
allCombos: null,
});
// Verify that the model IS locked for the actual connection
const lockedForConnFixed = isModelLocked(provider, connectionId, model);
assert.equal(lockedForConnFixed, true, "Model should be locked for the correct connection ID");
});