Files
OmniRoute/tests/unit/sync-bundle.test.ts
Diego Rodrigues de Sa e Souza 93265eede3 test(infra): retry recursive temp-dir removal on main (main twin of #11968) (#12246)
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)

`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.

* chore(scripts): carry the rm-maxretries codemod onto main alongside its output

The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
2026-09-01 01:48:00 -03:00

132 lines
4.6 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-sync-bundle-"));
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
const ORIGINAL_API_KEY_SECRET = process.env.API_KEY_SECRET;
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "test-sync-bundle-secret";
const core = await import("../../src/lib/db/core.ts");
const settingsDb = await import("../../src/lib/db/settings.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const combosDb = await import("../../src/lib/db/combos.ts");
const modelsDb = await import("../../src/lib/db/models.ts");
const apiKeysDb = await import("../../src/lib/db/apiKeys.ts");
const syncBundle = await import("../../src/lib/sync/bundle.ts");
function resetStorage() {
apiKeysDb.resetApiKeyState();
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(() => {
resetStorage();
});
test.after(() => {
apiKeysDb.resetApiKeyState();
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
if (ORIGINAL_DATA_DIR === undefined) {
delete process.env.DATA_DIR;
} else {
process.env.DATA_DIR = ORIGINAL_DATA_DIR;
}
if (ORIGINAL_API_KEY_SECRET === undefined) {
delete process.env.API_KEY_SECRET;
} else {
process.env.API_KEY_SECRET = ORIGINAL_API_KEY_SECRET;
}
});
test("config sync bundle is deterministic, strips auth settings, and ignores volatile fields", async () => {
await settingsDb.updateSettings({
theme: "midnight",
requireLogin: true,
password: "hashed-password",
cloudEnabled: true,
});
const connection = await providersDb.createProviderConnection({
provider: "openai",
authType: "apikey",
name: "Primary OpenAI",
apiKey: "sk-live-secret",
defaultModel: "gpt-4o-mini",
providerSpecificData: { region: "us" },
});
await modelsDb.setModelAlias("smart-default", "openai/gpt-4o-mini");
await combosDb.createCombo({
name: "primary",
models: ["openai/gpt-4o-mini"],
strategy: "priority",
});
const apiKey = await apiKeysDb.createApiKey("Desktop", "machine-sync-1");
await apiKeysDb.updateApiKeyPermissions(apiKey.id, {
modelAccessMode: "restricted",
allowedModels: [],
});
const first = await syncBundle.buildConfigSyncEnvelope();
const second = await syncBundle.buildConfigSyncEnvelope();
assert.equal(first.version, second.version);
assert.deepEqual(first.bundle, second.bundle);
assert.equal(first.bundle.settings.password, undefined);
assert.equal(first.bundle.settings.requireLogin, undefined);
assert.equal(first.bundle.settings.cloudEnabled, undefined);
assert.equal(first.bundle.providerConnections[0].apiKey, "sk-live-secret");
assert.equal(first.bundle.modelAliases["smart-default"], "openai/gpt-4o-mini");
assert.equal(first.bundle.apiKeys[0].modelAccessMode, "restricted");
assert.deepEqual(first.bundle.apiKeys[0].allowedModels, []);
assert.deepEqual(first.bundle.reasoningRoutingRules, []);
await providersDb.updateProviderConnection((connection as any).id, {
lastError: "temporary upstream failure",
lastErrorAt: "2026-04-14T12:00:00.000Z",
rateLimitedUntil: "2026-04-14T12:30:00.000Z",
});
const afterVolatileChange = await syncBundle.buildConfigSyncEnvelope();
assert.equal(afterVolatileChange.version, first.version);
await providersDb.updateProviderConnection((connection as any).id, {
defaultModel: "gpt-4.1-mini",
});
const afterConfigChange = await syncBundle.buildConfigSyncEnvelope();
assert.notEqual(afterConfigChange.version, first.version);
assert.equal(afterConfigChange.bundle.providerConnections[0].defaultModel, "gpt-4.1-mini");
});
test("reasoning sync reconciliation disables dangling references and reports conflicts", () => {
const result = syncBundle.reconcileReasoningRulesForSync(
[
{ id: "valid", scope: "global", targetKind: "keep", enabled: true },
{
id: "dangling",
scope: "apiKey",
apiKeyId: "missing-key",
targetKind: "combo",
targetComboId: "missing-combo",
enabled: true,
},
],
{ apiKeyIds: [], comboIds: [], connectionIds: [] }
);
assert.equal(result.rules[0].enabled, true);
assert.equal(result.rules[1].enabled, false);
assert.deepEqual(result.conflicts, [
{ ruleId: "dangling", missing: ["apiKeyId", "targetComboId"] },
]);
});