mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-15 19:32:20 +03:00
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
97 lines
3.4 KiB
TypeScript
97 lines
3.4 KiB
TypeScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
import {
|
|
applyAzureParamRules,
|
|
AZURE_COMPLETION_TOKEN_DEPLOYMENT,
|
|
} from "../../open-sse/executors/azureParamRules.ts";
|
|
import { getExecutor, AzureAiExecutor } from "../../open-sse/executors/index.ts";
|
|
|
|
/**
|
|
* Regression guards for two Azure 400s observed against a live Azure AI Foundry
|
|
* resource:
|
|
*
|
|
* azure-ai/gpt-chat-latest
|
|
* -> 400 "Unsupported parameter: 'max_tokens' is not supported with this
|
|
* model. Use 'max_completion_tokens' instead."
|
|
* azure-ai/<any gpt-5 deployment> with tools
|
|
* -> 400 "Function tools with reasoning_effort are not supported ...
|
|
* Please use /v1/responses instead."
|
|
*
|
|
* Both rules already existed inline in AzureOpenAIExecutor, so the identical
|
|
* deployment succeeded on the `azure-openai` connection and failed on
|
|
* `azure-ai`, which routed through the bare DefaultExecutor.
|
|
*/
|
|
|
|
test("gpt-chat-latest converts max_tokens to max_completion_tokens", () => {
|
|
const out = applyAzureParamRules(
|
|
"gpt-chat-latest",
|
|
{ max_tokens: 4096 },
|
|
{ max_tokens: 4096, messages: [] }
|
|
) as Record<string, unknown>;
|
|
|
|
assert.equal(out.max_tokens, undefined);
|
|
assert.equal(out.max_completion_tokens, 4096);
|
|
});
|
|
|
|
test("gpt-5 family converts max_tokens too", () => {
|
|
for (const model of ["gpt-5.1", "gpt-5.4-nano", "my-gpt-5-prod", "o3", "o4-mini"]) {
|
|
const out = applyAzureParamRules(model, { max_tokens: 100 }, { max_tokens: 100 }) as Record<
|
|
string,
|
|
unknown
|
|
>;
|
|
assert.equal(out.max_tokens, undefined, `${model} should drop max_tokens`);
|
|
assert.equal(out.max_completion_tokens, 100, `${model} should set max_completion_tokens`);
|
|
}
|
|
});
|
|
|
|
test("reasoning_effort is dropped when tools are present", () => {
|
|
const out = applyAzureParamRules(
|
|
"gpt-5.1",
|
|
{},
|
|
{ reasoning_effort: "high", tools: [{ name: "read_file" }] }
|
|
) as Record<string, unknown>;
|
|
|
|
assert.equal(out.reasoning_effort, undefined);
|
|
assert.equal((out.tools as unknown[]).length, 1);
|
|
});
|
|
|
|
test("reasoning_effort survives when there are no tools", () => {
|
|
const out = applyAzureParamRules("gpt-5.1", {}, { reasoning_effort: "high" }) as Record<
|
|
string,
|
|
unknown
|
|
>;
|
|
assert.equal(out.reasoning_effort, "high");
|
|
});
|
|
|
|
test("non-default temperature is dropped, temperature=1 kept", () => {
|
|
const dropped = applyAzureParamRules("gpt-5.1", {}, { temperature: 0.7 }) as Record<
|
|
string,
|
|
unknown
|
|
>;
|
|
assert.equal(dropped.temperature, undefined);
|
|
|
|
const kept = applyAzureParamRules("gpt-5.1", {}, { temperature: 1 }) as Record<string, unknown>;
|
|
assert.equal(kept.temperature, 1);
|
|
});
|
|
|
|
test("unaffected deployments pass through untouched", () => {
|
|
const body = { max_tokens: 500, temperature: 0.2, reasoning_effort: "low" };
|
|
const out = applyAzureParamRules("Phi-4", {}, body);
|
|
assert.deepEqual(out, body);
|
|
});
|
|
|
|
test("the regex does not match unrelated names by accident", () => {
|
|
assert.equal(AZURE_COMPLETION_TOKEN_DEPLOYMENT.test("gpt-4o-mini"), false);
|
|
assert.equal(AZURE_COMPLETION_TOKEN_DEPLOYMENT.test("DeepSeek-V4-Flash"), false);
|
|
assert.equal(AZURE_COMPLETION_TOKEN_DEPLOYMENT.test("Kimi-K2.7-Code"), false);
|
|
});
|
|
|
|
test("azure-ai resolves to AzureAiExecutor, not the bare DefaultExecutor", () => {
|
|
const executor = getExecutor("azure-ai");
|
|
assert.ok(
|
|
executor instanceof AzureAiExecutor,
|
|
"azure-ai must have its own executor so it inherits the Azure param rules"
|
|
);
|
|
});
|