mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-16 03:42:21 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
80 lines
2.9 KiB
TypeScript
80 lines
2.9 KiB
TypeScript
import { describe, it } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
const { OpencodeExecutor } = await import("../../open-sse/executors/opencode.ts");
|
|
|
|
/**
|
|
* Behavioral guards for the three type-only fixes in the TS 7 executor slice
|
|
* (see #8484). Each fix restored a type the code already depended on at runtime;
|
|
* these tests pin the runtime contracts so a future "simplification" of the
|
|
* annotations cannot silently change behavior.
|
|
*
|
|
* The zed-hosted `SseEnqueueTarget` fix is already covered end-to-end by
|
|
* `zed-hosted-think-close-marker.test.ts`, which drives the same TransformStream
|
|
* that failed to type-check — no duplicate added here.
|
|
*/
|
|
|
|
describe("OpencodeExecutor — tools truncation survives the narrowing fix", () => {
|
|
const executor = new OpencodeExecutor("opencode-go");
|
|
const CREDENTIALS = { apiKey: "k" } as Record<string, unknown>;
|
|
|
|
const tools = (n: number) =>
|
|
Array.from({ length: n }, (_, i) => ({
|
|
type: "function",
|
|
function: { name: `tool_${i}`, parameters: {} },
|
|
}));
|
|
|
|
function bodyWith(toolCount: number) {
|
|
return {
|
|
model: "oc/kimi-k2.6",
|
|
stream: true,
|
|
messages: [{ role: "user", content: "hi" }],
|
|
tools: tools(toolCount),
|
|
};
|
|
}
|
|
|
|
it("truncates an over-long tools array to 128 entries", () => {
|
|
const out = executor.transformRequest("oc/kimi-k2.6", bodyWith(200), true, CREDENTIALS) as {
|
|
tools: unknown[];
|
|
};
|
|
assert.equal(out.tools.length, 128, "upstream rejects more than 128 tools");
|
|
assert.deepEqual(
|
|
(out.tools[127] as { function: { name: string } }).function.name,
|
|
"tool_127",
|
|
"truncation keeps the first 128 in order, not an arbitrary slice"
|
|
);
|
|
});
|
|
|
|
it("leaves a within-limit tools array untouched", () => {
|
|
const out = executor.transformRequest("oc/kimi-k2.6", bodyWith(10), true, CREDENTIALS) as {
|
|
tools: unknown[];
|
|
};
|
|
assert.equal(out.tools.length, 10);
|
|
});
|
|
|
|
it("is a no-op when the body carries no tools", () => {
|
|
const body = {
|
|
model: "oc/kimi-k2.6",
|
|
stream: true,
|
|
messages: [{ role: "user", content: "hi" }],
|
|
};
|
|
const out = executor.transformRequest("oc/kimi-k2.6", body, true, CREDENTIALS) as Record<
|
|
string,
|
|
unknown
|
|
>;
|
|
assert.equal("tools" in out, false);
|
|
assert.ok(Array.isArray(out.messages), "messages preserved");
|
|
});
|
|
|
|
it("leaves an array-shaped body alone (pins the !Array.isArray guard)", () => {
|
|
// The pre-fix condition reached `.tools` on any object, arrays included, and
|
|
// relied on `Array.isArray(undefined)` short-circuiting. The explicit
|
|
// !Array.isArray() guard must keep that outcome identical.
|
|
const arrayBody = [{ role: "user", content: "hi" }] as unknown as Record<string, unknown>;
|
|
const out = executor.transformRequest("oc/kimi-k2.6", arrayBody, true, CREDENTIALS);
|
|
assert.ok(Array.isArray(out), "array body must pass through as an array");
|
|
assert.equal((out as unknown[]).length, 1);
|
|
});
|
|
});
|
|
|