Files
OmniRoute/tests/unit/8385-perkey-proxy-global-toggle.test.ts
Diego Rodrigues de Sa e Souza 93265eede3 test(infra): retry recursive temp-dir removal on main (main twin of #11968) (#12246)
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)

`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.

* chore(scripts): carry the rm-maxretries codemod onto main alongside its output

The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
2026-09-01 01:48:00 -03:00

118 lines
3.5 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-8385-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = "test-secret";
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const proxiesDb = await import("../../src/lib/db/proxies.ts");
const settingsDb = await import("../../src/lib/db/settings.ts");
const apiKeysDb = await import("../../src/lib/db/apiKeys.ts");
interface ConnectionRef {
id: string;
}
interface ProxyResolution {
level: string | null;
proxy: unknown;
}
async function resetStorage() {
delete process.env.INITIAL_PASSWORD;
core.resetDbInstance();
apiKeysDb.resetApiKeyState();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.after(async () => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("issue #8385: global perKeyProxyEnabled=false must override a connection's per_key_proxy_enabled=1", async () => {
await resetStorage();
core
.getDbInstance()
.prepare(
"INSERT OR REPLACE INTO key_value (namespace, key, value) VALUES ('settings', 'perKeyProxyEnabled', 'false')"
)
.run();
const conn = (await providersDb.createProviderConnection({
provider: "openai",
authType: "apikey",
name: "conn-8385",
apiKey: "sk-8385",
})) as unknown as ConnectionRef;
await providersDb.updateProviderConnection(conn.id, { perKeyProxyEnabled: true });
const proxy = await proxiesDb.createProxy({
name: "Per-Key Proxy 8385",
type: "http",
host: "perkey.8385.local",
port: 8080,
});
const key = await apiKeysDb.createApiKey("probe-8385-key", "machine-8385");
await apiKeysDb.updateApiKeyPermissions(key.id, { proxyId: proxy.id });
const resolved = (await settingsDb.resolveProxyForConnection(
conn.id,
key.id
)) as unknown as ProxyResolution;
assert.notEqual(
resolved?.level,
"apiKey",
`expected global-off to override per-key assignment, but got level=${resolved?.level} proxy=${JSON.stringify(resolved?.proxy)}`
);
});
test("issue #8385: global perKeyProxyEnabled=true still allows the per-key assignment to apply", async () => {
await resetStorage();
core
.getDbInstance()
.prepare(
"INSERT OR REPLACE INTO key_value (namespace, key, value) VALUES ('settings', 'perKeyProxyEnabled', 'true')"
)
.run();
const conn = (await providersDb.createProviderConnection({
provider: "openai",
authType: "apikey",
name: "conn-8385-on",
apiKey: "sk-8385-on",
})) as unknown as ConnectionRef;
await providersDb.updateProviderConnection(conn.id, { perKeyProxyEnabled: true });
const proxy = await proxiesDb.createProxy({
name: "Per-Key Proxy 8385 On",
type: "http",
host: "perkey-on.8385.local",
port: 8081,
});
const key = await apiKeysDb.createApiKey("probe-8385-key-on", "machine-8385-on");
await apiKeysDb.updateApiKeyPermissions(key.id, { proxyId: proxy.id });
const resolved = (await settingsDb.resolveProxyForConnection(
conn.id,
key.id
)) as unknown as ProxyResolution;
assert.equal(
resolved?.level,
"apiKey",
`expected global-on to allow the per-key assignment, but got level=${resolved?.level}`
);
});