mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-15 19:32:20 +03:00
93265eede3
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)
`main` has been red since b342c1a361 on the vitest and integration gates:
✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos
Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).
release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.
This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.
The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.
* chore(scripts): carry the rm-maxretries codemod onto main alongside its output
The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
70 lines
2.6 KiB
TypeScript
70 lines
2.6 KiB
TypeScript
/**
|
|
* GHSA-v54m-6rm3-p565 — /a2a sits outside the authz proxy matcher, so it never
|
|
* saw the REQUIRE_API_KEY posture and accepted every caller when OMNIROUTE_API_KEY
|
|
* was unset (the default). authenticate() now honors REQUIRE_API_KEY directly.
|
|
*/
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omni-a2a-require-key-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "a2a-require-key-secret";
|
|
process.env.OMNIROUTE_DISABLE_REDIS_AUTH_CACHE = "1";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const apiKeysDb = await import("../../src/lib/db/apiKeys.ts");
|
|
const route = await import("../../src/app/a2a/route.ts");
|
|
|
|
const ORIGINAL_REQUIRE = process.env.REQUIRE_API_KEY;
|
|
const ORIGINAL_A2A_KEY = process.env.OMNIROUTE_API_KEY;
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
if (ORIGINAL_REQUIRE === undefined) delete process.env.REQUIRE_API_KEY;
|
|
else process.env.REQUIRE_API_KEY = ORIGINAL_REQUIRE;
|
|
if (ORIGINAL_A2A_KEY === undefined) delete process.env.OMNIROUTE_API_KEY;
|
|
else process.env.OMNIROUTE_API_KEY = ORIGINAL_A2A_KEY;
|
|
});
|
|
|
|
function post(key?: string) {
|
|
return route.POST(
|
|
new Request("http://localhost/a2a", {
|
|
method: "POST",
|
|
headers: {
|
|
"content-type": "application/json",
|
|
...(key ? { authorization: `Bearer ${key}` } : {}),
|
|
},
|
|
body: JSON.stringify({ jsonrpc: "2.0", id: 1, method: "message/send", params: {} }),
|
|
}) as never
|
|
);
|
|
}
|
|
|
|
async function isUnauthorized(res: Response) {
|
|
const body = (await res.clone().json()) as { error?: { code?: number } };
|
|
return body.error?.code === -32600;
|
|
}
|
|
|
|
test("REQUIRE_API_KEY=true rejects an unkeyed /a2a call (GHSA-v54m)", async () => {
|
|
delete process.env.OMNIROUTE_API_KEY;
|
|
process.env.REQUIRE_API_KEY = "true";
|
|
assert.equal(await isUnauthorized(await post()), true, "no key must be rejected");
|
|
|
|
const key = await apiKeysDb.createApiKey("a2a-client", "machine-a2a", []);
|
|
assert.equal(
|
|
await isUnauthorized(await post(key.key)),
|
|
false,
|
|
"a valid key must clear the /a2a auth gate"
|
|
);
|
|
});
|
|
|
|
test("keyless local-first default still allows /a2a (posture preserved)", async () => {
|
|
delete process.env.REQUIRE_API_KEY;
|
|
delete process.env.OMNIROUTE_API_KEY;
|
|
assert.equal(await isUnauthorized(await post()), false, "keyless default must not 401");
|
|
});
|