mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-15 11:22:15 +03:00
93265eede3
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)
`main` has been red since b342c1a361 on the vitest and integration gates:
✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos
Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).
release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.
This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.
The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.
* chore(scripts): carry the rm-maxretries codemod onto main alongside its output
The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
74 lines
3.3 KiB
TypeScript
74 lines
3.3 KiB
TypeScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import fsp from "node:fs/promises";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// #8036: npm-installed CLIs (e.g. codex) are `#!/usr/bin/env node` shebang
|
|
// scripts. checkRunnable() in cliRuntime.ts builds a minimal spawn env whose
|
|
// PATH comes ONLY from the caller's PATH (getLookupEnv()), never merging in
|
|
// the running Node's own bin dir (path.dirname(process.execPath)) the way
|
|
// locateCommand's known-path search already does at :641. When the server is
|
|
// launched by a minimal-PATH launcher (systemd/docker/PM2) that lacks node's
|
|
// directory, `env node` inside the shebang can't resolve → healthcheck spawn
|
|
// fails → the CLI is (falsely) reported as not runnable even though it is
|
|
// correctly located.
|
|
//
|
|
// cliRuntime.ts computes EXPECTED_PARENT_PATHS from os.homedir() at MODULE
|
|
// LOAD time, so HOME must be redirected before the module is imported.
|
|
const sandboxHome = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-8036-home-"));
|
|
process.env.HOME = sandboxHome;
|
|
process.env.USERPROFILE = sandboxHome;
|
|
process.env.npm_config_prefix = path.join(sandboxHome, "npm-prefix-unused");
|
|
delete process.env.CLI_CODEX_BIN;
|
|
delete process.env.CLI_EXTRA_PATHS;
|
|
|
|
// Place the fake `codex` npm-shebang script at a KNOWN install location
|
|
// (home/.local/bin, within EXPECTED_PARENT_PATHS) so it's located via the
|
|
// PATH-independent known-path search — exactly like a real npm global
|
|
// install would be found — isolating the test from PATH-dependent `sh`/
|
|
// `command -v` resolution and from this test-runner box's own PATH.
|
|
const localBinDir = path.join(sandboxHome, ".local", "bin");
|
|
fs.mkdirSync(localBinDir, { recursive: true });
|
|
const codexScriptPath = path.join(localBinDir, "codex");
|
|
fs.writeFileSync(
|
|
codexScriptPath,
|
|
["#!/usr/bin/env node", 'console.log("codex-cli 0.145.0-test");', ""].join("\n")
|
|
);
|
|
fs.chmodSync(codexScriptPath, 0o755);
|
|
|
|
const nodeBinDir = path.dirname(process.execPath);
|
|
|
|
const { getCliRuntimeStatus } = await import("../../src/shared/services/cliRuntime.ts");
|
|
|
|
test("#8036: codex is reported runnable even when the launcher PATH omits node's own bin dir", async () => {
|
|
const originalPath = process.env.PATH;
|
|
// Bogus PATH: no `sh`/`env`/system dirs, and — crucially — no node's own
|
|
// bin dir. The known-path match above never needs PATH to LOCATE codex;
|
|
// this isolates whether checkRunnable()'s healthcheck spawn can still
|
|
// RUN it (the `#!/usr/bin/env node` shebang needs `node` resolvable via
|
|
// the child's PATH).
|
|
process.env.PATH = path.join(sandboxHome, "nonexistent-launcher-path");
|
|
try {
|
|
const status = await getCliRuntimeStatus("codex");
|
|
assert.equal(
|
|
status.installed,
|
|
true,
|
|
`expected installed=true but got installed=${status.installed} reason=${status.reason}`
|
|
);
|
|
assert.equal(
|
|
status.runnable,
|
|
true,
|
|
`expected runnable=true but got runnable=${status.runnable} reason=${status.reason} ` +
|
|
`(launcher PATH lacked node's bin dir ${nodeBinDir} — checkRunnable() must merge it in)`
|
|
);
|
|
} finally {
|
|
process.env.PATH = originalPath;
|
|
}
|
|
});
|
|
|
|
test.after(async () => {
|
|
await fsp.rm(sandboxHome, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|