mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-15 19:32:20 +03:00
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)
`main` has been red since b342c1a361 on the vitest and integration gates:
✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos
Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).
release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.
This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.
The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.
* chore(scripts): carry the rm-maxretries codemod onto main alongside its output
The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
125 lines
3.9 KiB
TypeScript
125 lines
3.9 KiB
TypeScript
/**
|
|
* Tests for speech combo strategy execution
|
|
*
|
|
* Mirrors tests/unit/combo/image-combo.test.ts. executeSpeechCombo takes no
|
|
* logger argument — the speech handler returns a Response directly rather than
|
|
* a result object, so there is nothing for the strategy to log through.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-speech-combo-"));
|
|
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.JWT_SECRET = "test-jwt-secret-for-speech-combo-tests";
|
|
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
|
|
const core = await import("@/lib/db/core.ts");
|
|
const { createCombo } = await import("@/lib/db/combos");
|
|
const { executeSpeechCombo } = await import("@omniroute/open-sse/services/speechCombo");
|
|
|
|
function createRequest(model: string): Request {
|
|
return new Request("http://localhost:20128/v1/audio/speech", {
|
|
method: "POST",
|
|
headers: { "Content-Type": "application/json" },
|
|
body: JSON.stringify({ model, input: "hello there" }),
|
|
});
|
|
}
|
|
|
|
function createMockAuth() {
|
|
return {
|
|
request: createRequest("test-combo"),
|
|
policy: { apiKeyInfo: { id: "test-key", name: "test-key" } },
|
|
};
|
|
}
|
|
|
|
async function cleanupTestDataDir() {
|
|
let lastError: unknown;
|
|
for (let attempt = 0; attempt < 5; attempt += 1) {
|
|
try {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
return;
|
|
} catch (error: unknown) {
|
|
lastError = error;
|
|
await new Promise((resolve) => setTimeout(resolve, 25));
|
|
}
|
|
}
|
|
if (lastError) throw lastError;
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await cleanupTestDataDir();
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
});
|
|
|
|
test.after(async () => {
|
|
process.env.DATA_DIR = ORIGINAL_DATA_DIR;
|
|
await cleanupTestDataDir();
|
|
});
|
|
|
|
test("returns 400 when combo is not found", async () => {
|
|
const response = await executeSpeechCombo(
|
|
"nonexistent-combo",
|
|
{ model: "nonexistent-combo", input: "hello there" },
|
|
createMockAuth(),
|
|
Date.now()
|
|
);
|
|
assert.equal(response.status, 400);
|
|
const bodyStr = JSON.stringify(await response.json());
|
|
assert.ok(!bodyStr.includes("at "), "Error response does not leak stack traces");
|
|
});
|
|
|
|
test("returns 400 when combo has no speech-capable targets", async () => {
|
|
await createCombo({
|
|
name: "chat-only-combo",
|
|
strategy: "priority",
|
|
models: ["openai/gpt-4o"],
|
|
});
|
|
|
|
const response = await executeSpeechCombo(
|
|
"chat-only-combo",
|
|
{ model: "chat-only-combo", input: "hello there" },
|
|
createMockAuth(),
|
|
Date.now()
|
|
);
|
|
assert.equal(response.status, 400);
|
|
const bodyStr = JSON.stringify(await response.json());
|
|
assert.ok(bodyStr.includes("No speech-capable targets"), "Tells user no speech targets");
|
|
assert.ok(!bodyStr.includes("at "), "Error response does not leak stack traces");
|
|
});
|
|
|
|
test("returns 400 when combo has no usable targets", async () => {
|
|
await createCombo({ name: "empty-combo", strategy: "priority", models: [] });
|
|
|
|
const response = await executeSpeechCombo(
|
|
"empty-combo",
|
|
{ model: "empty-combo", input: "hello there" },
|
|
createMockAuth(),
|
|
Date.now()
|
|
);
|
|
assert.equal(response.status, 400);
|
|
});
|
|
|
|
test("fails cleanly when speech targets exist but no provider connection does", async () => {
|
|
await createCombo({
|
|
name: "spc-no-conn",
|
|
strategy: "fill-first",
|
|
models: ["deepgram/aura-asteria-en"],
|
|
});
|
|
|
|
const response = await executeSpeechCombo(
|
|
"spc-no-conn",
|
|
{ model: "spc-no-conn", input: "hello there" },
|
|
createMockAuth(),
|
|
Date.now()
|
|
);
|
|
assert.ok(response.status >= 400, "Surfaces a failure rather than a fake success");
|
|
const bodyStr = JSON.stringify(await response.json());
|
|
assert.ok(!bodyStr.includes("at "), "Error response does not leak stack traces");
|
|
});
|