Files
OmniRoute/tests/unit/conversationTurnContent.test.ts
Diego Rodrigues de Sa e Souza 93265eede3 test(infra): retry recursive temp-dir removal on main (main twin of #11968) (#12246)
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)

`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.

* chore(scripts): carry the rm-maxretries codemod onto main alongside its output

The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
2026-09-01 01:48:00 -03:00

142 lines
5.1 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
// conversationTurnContent.ts resolves a conversation_turn_nodes row's actual
// display text/tool-call shape on demand from the call-log artifact its
// last_correlation_id points at (migration 156 dropped the old stored
// text_preview/block_kind/tool_name columns -- see conversationTracker.ts).
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-conv-turn-content-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const { hashTurnContent } = await import("../../open-sse/services/conversationTracker.ts");
const { resolveTurnDisplayContent } =
await import("../../open-sse/services/conversationTurnContent.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
function insertCallLog(row: { id: string; correlationId: string; artifactRelPath: string | null }) {
const db = core.getDbInstance();
db.prepare(
`INSERT INTO call_logs (id, timestamp, method, path, status, model, correlation_id, artifact_relpath)
VALUES (?, ?, 'POST', '/v1/chat/completions', 200, 'big-pickle', ?, ?)`
).run(row.id, new Date().toISOString(), row.correlationId, row.artifactRelPath);
}
function writeArtifact(relPath: string, clientRawRequestBody: unknown) {
const absPath = path.join(TEST_DATA_DIR, "call_logs", relPath);
fs.mkdirSync(path.dirname(absPath), { recursive: true });
fs.writeFileSync(
absPath,
JSON.stringify({
schemaVersion: 5,
requestBody: null,
responseBody: null,
error: null,
pipeline: {
clientRawRequest: { body: clientRawRequestBody },
},
})
);
}
test("resolveTurnDisplayContent resolves plain text turns from the artifact's raw request body", () => {
insertCallLog({ id: "log-1", correlationId: "corr-1", artifactRelPath: "2026-01-01/log-1.json" });
writeArtifact("2026-01-01/log-1.json", {
messages: [
{ role: "user", content: "hello there" },
{ role: "assistant", content: "hi!" },
],
});
const result = resolveTurnDisplayContent([{ lastCorrelationId: "corr-1" }]);
const userHash = hashTurnContent({
role: "user",
text: "hello there",
blockKind: "text",
toolName: null,
});
assert.deepEqual(result.get(userHash), {
textPreview: "hello there",
blockKind: "text",
toolName: null,
});
});
test("resolveTurnDisplayContent resolves tool_use/tool_result shape, full and untruncated", () => {
const bigArgs = JSON.stringify({ path: "/tmp/big.md", content: "line\n".repeat(2000) });
insertCallLog({ id: "log-2", correlationId: "corr-2", artifactRelPath: "2026-01-01/log-2.json" });
writeArtifact("2026-01-01/log-2.json", {
input: [{ type: "function_call", name: "write", call_id: "c1", arguments: bigArgs }],
});
const result = resolveTurnDisplayContent([{ lastCorrelationId: "corr-2" }]);
const hash = hashTurnContent({
role: "tool",
text: bigArgs,
blockKind: "tool_use",
toolName: "write",
});
const content = result.get(hash);
assert.equal(content?.blockKind, "tool_use");
assert.equal(content?.toolName, "write");
// No 8000-char truncation anymore -- the full raw arguments string survives.
assert.equal(content?.textPreview, bigArgs);
assert.ok(content!.textPreview.length > 8000);
});
test("resolveTurnDisplayContent groups nodes by correlation id, reading each artifact once", () => {
insertCallLog({ id: "log-3", correlationId: "corr-3", artifactRelPath: "2026-01-01/log-3.json" });
writeArtifact("2026-01-01/log-3.json", {
messages: [
{ role: "user", content: "a" },
{ role: "assistant", content: "b" },
{ role: "user", content: "c" },
],
});
const result = resolveTurnDisplayContent([
{ lastCorrelationId: "corr-3" },
{ lastCorrelationId: "corr-3" },
{ lastCorrelationId: "corr-3" },
]);
for (const [role, text] of [
["user", "a"],
["assistant", "b"],
["user", "c"],
] as const) {
const hash = hashTurnContent({ role, text, blockKind: "text", toolName: null });
assert.equal(result.get(hash)?.textPreview, text);
}
});
test("resolveTurnDisplayContent skips nodes with no correlation id without throwing", () => {
const result = resolveTurnDisplayContent([{ lastCorrelationId: null }]);
assert.equal(result.size, 0);
});
test("resolveTurnDisplayContent omits content for an unresolvable correlation id (missing call_logs row, purged artifact, or no pipeline captured)", () => {
const missingRow = resolveTurnDisplayContent([{ lastCorrelationId: "corr-does-not-exist" }]);
assert.equal(missingRow.size, 0);
insertCallLog({ id: "log-4", correlationId: "corr-4", artifactRelPath: null });
const noArtifact = resolveTurnDisplayContent([{ lastCorrelationId: "corr-4" }]);
assert.equal(noArtifact.size, 0);
insertCallLog({
id: "log-5",
correlationId: "corr-5",
artifactRelPath: "2026-01-01/does-not-exist.json",
});
const missingFile = resolveTurnDisplayContent([{ lastCorrelationId: "corr-5" }]);
assert.equal(missingFile.size, 0);
});