mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-15 19:32:20 +03:00
93265eede3
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)
`main` has been red since b342c1a361 on the vitest and integration gates:
✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos
Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).
release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.
This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.
The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.
* chore(scripts): carry the rm-maxretries codemod onto main alongside its output
The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
75 lines
2.5 KiB
TypeScript
75 lines
2.5 KiB
TypeScript
/**
|
|
* #7938 — privileged MITM steps (cert trust, DNS) must be skippable when no sudo password.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { EventEmitter } from "node:events";
|
|
import {
|
|
canRunPrivilegedMitmSteps,
|
|
isMitmSudoPasswordRequired,
|
|
} from "../../src/mitm/sudoGate.ts";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-mitm-sudo-gate-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const manager = await import("../../src/mitm/manager.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("canRunPrivilegedMitmSteps is false when isMitmSudoPasswordRequired is true", () => {
|
|
assert.equal(canRunPrivilegedMitmSteps("secret"), !isMitmSudoPasswordRequired("secret"));
|
|
});
|
|
|
|
test("canRunPrivilegedMitmSteps is false for empty password on POSIX sudo-required hosts", () => {
|
|
if (process.platform === "win32") return;
|
|
const isRootUser = !!(process.getuid && process.getuid() === 0);
|
|
if (isRootUser) return;
|
|
if (!isMitmSudoPasswordRequired("")) return;
|
|
assert.equal(canRunPrivilegedMitmSteps(""), false);
|
|
});
|
|
|
|
test("stopMitm skips DNS teardown without sudo password but still kills server (#7938)", async () => {
|
|
if (process.platform === "win32") return;
|
|
const isRootUser = !!(process.getuid && process.getuid() === 0);
|
|
if (isRootUser) return;
|
|
if (!isMitmSudoPasswordRequired("")) return;
|
|
|
|
const events: string[] = [];
|
|
const fakeProc = new EventEmitter() as EventEmitter & {
|
|
killed: boolean;
|
|
kill: (signal?: string) => boolean;
|
|
};
|
|
fakeProc.killed = false;
|
|
fakeProc.kill = (signal?: string) => {
|
|
events.push(`kill:${signal}`);
|
|
fakeProc.killed = true;
|
|
return true;
|
|
};
|
|
|
|
manager.__setServerProcessForTest(fakeProc as unknown as import("child_process").ChildProcess, 4242);
|
|
|
|
await manager.stopMitm("", {
|
|
removeDNSEntry: async () => {
|
|
events.push("removeDNSEntry");
|
|
},
|
|
removeDNSEntries: async () => {
|
|
events.push("removeDNSEntries");
|
|
},
|
|
collectManagedHosts: () => ["fake.example.test"],
|
|
});
|
|
|
|
assert.equal(
|
|
events.filter((event) => event.startsWith("remove")).length,
|
|
0,
|
|
"must not invoke DNS teardown with empty sudo password"
|
|
);
|
|
assert.ok(events.some((event) => event.startsWith("kill:")), "server process must still be stopped");
|
|
});
|