Files
OmniRoute/tests/unit/proxy-egress-validate-pool-default.test.ts
Diego Rodrigues de Sa e Souza 93265eede3 test(infra): retry recursive temp-dir removal on main (main twin of #11968) (#12246)
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)

`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.

* chore(scripts): carry the rm-maxretries codemod onto main alongside its output

The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
2026-09-01 01:48:00 -03:00

70 lines
2.6 KiB
TypeScript

/**
* Regression guard (PR #7046 / perf-api-pagination fallout): src/lib/db/proxies.ts
* `listProxies()` was changed to return `{ items, total }` for pagination, but
* validateProxyPool()'s DEFAULT (non-injected) implementation still did
* `const proxies = await listProxies(); for (const p of proxies) ...` — iterating
* the paginated envelope object instead of `.items` crashes at runtime
* ("proxies is not iterable"). src/app/api/settings/proxies/egress/route.ts calls
* validateProxyPool() with no deps, so this is the real, exercised production path.
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-egress-default-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const proxiesDb = await import("../../src/lib/db/proxies.ts");
const egress = await import("../../src/lib/proxyEgress.ts");
const { validateProxyPool, _setEgressProbeForTests, clearEgressCache } = egress as unknown as {
validateProxyPool: (deps?: unknown) => Promise<
Array<{ proxyId: string; alive: boolean; newStatus: string }>
>;
_setEgressProbeForTests: (fn: unknown) => void;
clearEgressCache: () => void;
};
async function resetStorage() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(async () => {
await resetStorage();
clearEgressCache();
});
test.after(() => {
_setEgressProbeForTests(null);
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("validateProxyPool() with no injected deps does not crash on the real listProxies() {items,total} shape", async () => {
await proxiesDb.createProxy({
name: "Default Path Proxy",
type: "http",
host: "default-path.local",
port: 8080,
});
_setEgressProbeForTests(async (proxyUrl: string | null) => ({
ip: proxyUrl ? "203.0.113.9" : null,
latencyMs: 3,
}));
const report = await validateProxyPool();
assert.equal(Array.isArray(report), true, "validateProxyPool must resolve to an array");
assert.equal(report.length, 1);
assert.equal(report[0].alive, true);
assert.equal(report[0].newStatus, "active");
const { items: proxies } = await proxiesDb.listProxies({ includeSecrets: false });
assert.equal(proxies[0].status, "active", "markStatus default path must persist via updateProxy");
});