Files
OmniRoute/tests/unit/reasoning-token-buffer-9507.test.ts
Diego Rodrigues de Sa e Souza 93265eede3 test(infra): retry recursive temp-dir removal on main (main twin of #11968) (#12246)
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)

`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.

* chore(scripts): carry the rm-maxretries codemod onto main alongside its output

The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
2026-09-01 01:48:00 -03:00

45 lines
1.6 KiB
TypeScript

/**
* #9507 — client max_tokens must NEVER be rewritten upward by the
* reasoning-token buffer. Core contract from #1761: OmniRoute must not
* silently enlarge a Claude Max user's per-turn cost.
*
* On claude-opus-5 (registry maxOutputTokens = 128000), a client sending
* max_tokens: 64000 got rewritten to 96000 (Math.ceil(64000 * 1.5)) because
* 96000 < 128000 so the "fits in cap" guard did NOT rescue it.
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-9507-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const { resolveReasoningBufferedMaxTokens } =
await import("../../open-sse/services/reasoningTokenBuffer.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("#9507 reasoning buffer does NOT enlarge a Claude opus-5 client budget upward", () => {
const result = resolveReasoningBufferedMaxTokens("anthropic/claude-opus-5", 64000);
assert.equal(
result,
64000,
`client max_tokens=64000 must be forwarded verbatim, got ${result} (x1.5 upward rewrite)`
);
});
test("#9507 reasoning buffer does NOT enlarge a Claude sonnet-5 client budget upward", () => {
const client = 32000;
const result = resolveReasoningBufferedMaxTokens("anthropic/claude-sonnet-5", client);
assert.ok(
result === null || result <= client,
`client max_tokens=${client} must not be enlarged, got ${result}`
);
});