Files
OmniRoute/tests/unit/reset-connection-backoff.test.ts
Diego Rodrigues de Sa e Souza 93265eede3 test(infra): retry recursive temp-dir removal on main (main twin of #11968) (#12246)
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)

`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.

* chore(scripts): carry the rm-maxretries codemod onto main alongside its output

The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
2026-09-01 01:48:00 -03:00

106 lines
3.9 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
// resetConnectionBackoff (open-sse perf PR #7893) is a lightweight-UPDATE variant
// of the CAS-based clearConnectionErrorIfUnchanged pattern: it resets the backoff
// and error columns without a preceding SELECT/re-encrypt/backup pass. It had zero
// direct test coverage prior to this file — regression guard added per Hard Rule #8.
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-reset-backoff-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = "test-reset-connection-backoff-secret";
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
async function createBackedOffConnection() {
const created = await providersDb.createProviderConnection({
provider: "glm",
authType: "apikey",
name: `GLM Backoff ${Date.now()}-${Math.random()}`,
apiKey: "glm-test-key",
});
const connectionId = (created as { id: string }).id;
// backoffLevel/error fields aren't accepted at creation time — set them via
// updateProviderConnection to reach the "backed off" state under test, mirroring
// the pattern in tests/unit/provider-limits-recovery.test.ts.
await providersDb.updateProviderConnection(connectionId, {
testStatus: "unavailable",
lastError: "rate limit exceeded",
lastErrorType: "rate_limited",
lastErrorSource: "executor",
errorCode: 429,
backoffLevel: 3,
});
return created;
}
test("resetConnectionBackoff clears backoff/error columns and re-activates the connection", async () => {
const created = await createBackedOffConnection();
const connectionId = (created as { id: string }).id;
const before = (await providersDb.getProviderConnectionById(connectionId)) as Record<
string,
unknown
>;
assert.equal(before.testStatus, "unavailable");
assert.equal(before.backoffLevel, 3);
await providersDb.resetConnectionBackoff(connectionId);
const after = (await providersDb.getProviderConnectionById(connectionId)) as Record<
string,
unknown
>;
assert.equal(after.testStatus, "active");
assert.equal(after.backoffLevel, 0);
assert.equal(after.lastError, undefined);
assert.equal(after.lastErrorType, undefined);
assert.equal(after.errorCode, undefined);
});
test("resetConnectionBackoff does not clear a terminal status (e.g. banned)", async () => {
const created = await providersDb.createProviderConnection({
provider: "glm",
authType: "apikey",
name: `GLM Banned ${Date.now()}-${Math.random()}`,
apiKey: "glm-test-key",
});
const connectionId = (created as { id: string }).id;
await providersDb.updateProviderConnection(connectionId, {
testStatus: "banned",
lastError: "account banned",
lastErrorType: "banned",
backoffLevel: 5,
});
// resetConnectionBackoff is a targeted UPDATE with no CAS/status guard — callers
// are responsible for only invoking it on connections eligible for reset. This
// test documents that unconditional behavior: it WILL flip a terminal status too,
// which is why callers must gate the call themselves (see comment on the fn).
await providersDb.resetConnectionBackoff(connectionId);
const after = (await providersDb.getProviderConnectionById(connectionId)) as Record<
string,
unknown
>;
assert.equal(after.testStatus, "active");
assert.equal(after.backoffLevel, 0);
});
test("resetConnectionBackoff is a no-op for an empty id", async () => {
await assert.doesNotReject(() => providersDb.resetConnectionBackoff(""));
});
test("resetConnectionBackoff is a no-op for an unknown id (no throw)", async () => {
await assert.doesNotReject(() => providersDb.resetConnectionBackoff("nonexistent-connection-id"));
});