mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-16 03:42:21 +03:00
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)
`main` has been red since b342c1a361 on the vitest and integration gates:
✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos
Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).
release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.
This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.
The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.
* chore(scripts): carry the rm-maxretries codemod onto main alongside its output
The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
160 lines
5.1 KiB
TypeScript
160 lines
5.1 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// OmniRoute-native `previous_response_id` virtualization: resolvePreviousResponseState
|
|
// resolves a response id back to the full input/output a prior call produced by
|
|
// reading the already-persisted call-log artifact, so a later request can be
|
|
// reconstructed to full history server-side without duplicating conversation
|
|
// content into a second store.
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-responses-continuation-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const store = await import("../../src/lib/db/responsesContinuationStore.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
function insertCallLog(row: {
|
|
id: string;
|
|
responseId: string | null;
|
|
apiKeyId: string | null;
|
|
detailState: string;
|
|
artifactRelPath: string | null;
|
|
}) {
|
|
const db = core.getDbInstance();
|
|
db.prepare(
|
|
`INSERT INTO call_logs
|
|
(id, timestamp, method, path, status, model, provider, account, duration,
|
|
tokens_in, tokens_out, api_key_id, detail_state, artifact_relpath, response_id)
|
|
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`
|
|
).run(
|
|
row.id,
|
|
new Date().toISOString(),
|
|
"POST",
|
|
"/v1/responses",
|
|
200,
|
|
"gpt-5.4-pro",
|
|
"openai",
|
|
"acc1",
|
|
100,
|
|
10,
|
|
20,
|
|
row.apiKeyId,
|
|
row.detailState,
|
|
row.artifactRelPath,
|
|
row.responseId
|
|
);
|
|
}
|
|
|
|
function writeArtifact(relPath: string, pipeline: Record<string, unknown>) {
|
|
const absPath = path.join(TEST_DATA_DIR, "call_logs", relPath);
|
|
fs.mkdirSync(path.dirname(absPath), { recursive: true });
|
|
fs.writeFileSync(
|
|
absPath,
|
|
JSON.stringify({
|
|
schemaVersion: 5,
|
|
summary: {},
|
|
requestBody: null,
|
|
responseBody: null,
|
|
error: null,
|
|
pipeline,
|
|
})
|
|
);
|
|
}
|
|
|
|
test("resolvePreviousResponseState reconstructs input/output from the call-log artifact", () => {
|
|
insertCallLog({
|
|
id: "log-1",
|
|
responseId: "resp_abc",
|
|
apiKeyId: "key-1",
|
|
detailState: "ready",
|
|
artifactRelPath: "2026-01-01/log-1.json",
|
|
});
|
|
writeArtifact("2026-01-01/log-1.json", {
|
|
providerRequest: { body: { input: [{ type: "message", role: "user", content: "hi" }] } },
|
|
clientResponse: {
|
|
id: "resp_abc",
|
|
output: [{ type: "message", role: "assistant", content: "hello" }],
|
|
},
|
|
});
|
|
|
|
const result = store.resolvePreviousResponseState("resp_abc", "key-1");
|
|
assert.deepEqual(result, {
|
|
input: [{ type: "message", role: "user", content: "hi" }],
|
|
output: [{ type: "message", role: "assistant", content: "hello" }],
|
|
});
|
|
});
|
|
|
|
test("resolvePreviousResponseState returns null for an unknown response id", () => {
|
|
const result = store.resolvePreviousResponseState("resp_does_not_exist", "key-1");
|
|
assert.equal(result, null);
|
|
});
|
|
|
|
test("resolvePreviousResponseState never crosses tenants (scoped by api_key_id)", () => {
|
|
insertCallLog({
|
|
id: "log-2",
|
|
responseId: "resp_tenant_a",
|
|
apiKeyId: "key-a",
|
|
detailState: "ready",
|
|
artifactRelPath: "2026-01-01/log-2.json",
|
|
});
|
|
writeArtifact("2026-01-01/log-2.json", {
|
|
providerRequest: { body: { input: [{ role: "user", content: "secret" }] } },
|
|
clientResponse: { id: "resp_tenant_a", output: [{ role: "assistant", content: "reply" }] },
|
|
});
|
|
|
|
assert.equal(store.resolvePreviousResponseState("resp_tenant_a", "key-b"), null);
|
|
assert.equal(store.resolvePreviousResponseState("resp_tenant_a", null), null);
|
|
assert.notEqual(store.resolvePreviousResponseState("resp_tenant_a", "key-a"), null);
|
|
});
|
|
|
|
test("resolvePreviousResponseState returns null when the artifact is missing on disk", () => {
|
|
insertCallLog({
|
|
id: "log-3",
|
|
responseId: "resp_missing_file",
|
|
apiKeyId: "key-1",
|
|
detailState: "ready",
|
|
artifactRelPath: "2026-01-01/does-not-exist.json",
|
|
});
|
|
|
|
assert.equal(store.resolvePreviousResponseState("resp_missing_file", "key-1"), null);
|
|
});
|
|
|
|
test("resolvePreviousResponseState fails closed when the pipeline payload was size-limit-omitted", () => {
|
|
insertCallLog({
|
|
id: "log-4",
|
|
responseId: "resp_omitted",
|
|
apiKeyId: "key-1",
|
|
detailState: "ready",
|
|
artifactRelPath: "2026-01-01/log-4.json",
|
|
});
|
|
// A size-limit-omitted payload is replaced with a placeholder string, not
|
|
// an object -- resolvePreviousResponseState must never try to reconstruct
|
|
// from it and silently drop history.
|
|
writeArtifact("2026-01-01/log-4.json", {
|
|
providerRequest: { body: "[omitted: call log artifact size limit exceeded]" },
|
|
clientResponse: { id: "resp_omitted", output: [] },
|
|
});
|
|
|
|
assert.equal(store.resolvePreviousResponseState("resp_omitted", "key-1"), null);
|
|
});
|
|
|
|
test("resolvePreviousResponseState returns null when detail logging was never captured for this row", () => {
|
|
insertCallLog({
|
|
id: "log-5",
|
|
responseId: "resp_no_detail",
|
|
apiKeyId: "key-1",
|
|
detailState: "none",
|
|
artifactRelPath: null,
|
|
});
|
|
|
|
assert.equal(store.resolvePreviousResponseState("resp_no_detail", "key-1"), null);
|
|
});
|