Files
OmniRoute/tests/unit/router-eval-compare.test.ts
Diego Rodrigues de Sa e Souza 93265eede3 test(infra): retry recursive temp-dir removal on main (main twin of #11968) (#12246)
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)

`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.

* chore(scripts): carry the rm-maxretries codemod onto main alongside its output

The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
2026-09-01 01:48:00 -03:00

84 lines
2.2 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import { mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { spawnSync } from "node:child_process";
const compareScript = "scripts/router-eval/compare.ts";
test("router eval compare retains named comparison artifacts", () => {
const dir = mkdtempSync(join(tmpdir(), "router-eval-compare-"));
const baseline = join(dir, "baseline.ndjson");
const candidate = join(dir, "candidate.ndjson");
const artifactDir = join(dir, "artifacts");
const runId = "policy-a-vs-policy-b";
writeFileSync(
baseline,
JSON.stringify({
sampleId: "b1",
configId: "policy-a",
selectedModel: "gpt-4.1",
expectedModel: "gpt-4.1",
latencyMs: 140,
costUsd: 0.004,
success: true,
})
);
writeFileSync(
candidate,
JSON.stringify({
sampleId: "c1",
configId: "policy-b",
selectedModel: "gpt-4.1",
expectedModel: "gpt-4.1",
latencyMs: 130,
costUsd: 0.004,
success: true,
})
);
const result = spawnSync(
process.execPath,
[
"--import",
"tsx",
compareScript,
"--baseline",
baseline,
"--candidate",
candidate,
"--baseline-name",
"policy-a",
"--candidate-name",
"policy-b",
"--artifact-dir",
artifactDir,
"--run-id",
runId,
],
{ encoding: "utf8" }
);
try {
assert.equal(result.status, 0);
assert.ok((result.stdout ?? "").includes("Router Eval Comparison"));
const runDir = join(artifactDir, runId);
assert.ok(
readFileSync(join(runDir, "router-eval.md"), "utf8").includes("Router Eval Comparison")
);
assert.ok(
readFileSync(join(runDir, "router-eval.json"), "utf8").includes("router-eval-comparison")
);
const comparison = JSON.parse(readFileSync(join(runDir, "comparison.json"), "utf8")) as Record<
string,
unknown
>;
assert.equal(comparison.baselineName, "policy-a");
assert.equal(comparison.candidateName, "policy-b");
} finally {
rmSync(dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
});