The Vitest job is a BLOCKING gate that had not run to completion once in this whole
release: rounds 1-3 cancelled it via cancel-in-progress on each successive fix push,
so its red was indistinguishable from green. Round 4 finally ran it and the suite was
broken cycle-wide.
Root cause of the suite: #7935 instrumented ~180 shared/dashboard components with
next-intl's useTranslations/useLocale without updating the tests that mount them, so
every one of them threw "context from NextIntlClientProvider was not found". Fixed at
the shared seam (tests/_setup/vitestUiPolyfills.ts) rather than per file: a translator
built from the REAL en.json via next-intl's own createTranslator, memoized per
namespace — the naive version returns a fresh function each call and any component
whose useCallback/useEffect depends on t spins forever, which reads as a hang, not a
failure. A local mock still wins over the default. 22 files fixed by the seam alone,
15 realigned to the real strings; no assert removed or weakened.
Two production bugs the suite was hiding, both pre-existing and both with a failing
regression test already in the tree:
- RequestLoggerDetail crashed on a structured error object. #7920 gave the component
formatErrorForDisplay for exactly this case, then #8213's combo-503 / cooldown
checks went to the raw field and called .toLowerCase() on it. Both paths now use
the helper.
- The logs detail modal reopened on first close again. #6830 fixed that by reading the
deep-link id ONCE; the #8354 page rewrite regressed it by reading the live
searchParams every render, so the prop flips mid-session and re-fires the child's
deep-link effect exactly as the modal closes. Frozen at mount again.
Also tightens i18nUiCoverage 75.5 -> 99, which the ratchet demanded under
--require-tighten: the metric genuinely improved as the async translation workflow
paid off the debt that the v3.8.39/.44/.47 rebaselines had been recording. The
collector subtracts placeholders, so this release's 317 __MISSING__ markers are
already netted out of the 99.
Two UI files still fail locally under 20-worker concurrency (combos-page-smoke,
evals-tab-smoke) — cold-import flakes that pass isolated and with a larger timeout.
f9fbb54fd9