mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-05 14:52:09 +03:00
The Vitest job is a BLOCKING gate that had not run to completion once in this whole release: rounds 1-3 cancelled it via cancel-in-progress on each successive fix push, so its red was indistinguishable from green. Round 4 finally ran it and the suite was broken cycle-wide. Root cause of the suite: #7935 instrumented ~180 shared/dashboard components with next-intl's useTranslations/useLocale without updating the tests that mount them, so every one of them threw "context from NextIntlClientProvider was not found". Fixed at the shared seam (tests/_setup/vitestUiPolyfills.ts) rather than per file: a translator built from the REAL en.json via next-intl's own createTranslator, memoized per namespace — the naive version returns a fresh function each call and any component whose useCallback/useEffect depends on t spins forever, which reads as a hang, not a failure. A local mock still wins over the default. 22 files fixed by the seam alone, 15 realigned to the real strings; no assert removed or weakened. Two production bugs the suite was hiding, both pre-existing and both with a failing regression test already in the tree: - RequestLoggerDetail crashed on a structured error object. #7920 gave the component formatErrorForDisplay for exactly this case, then #8213's combo-503 / cooldown checks went to the raw field and called .toLowerCase() on it. Both paths now use the helper. - The logs detail modal reopened on first close again. #6830 fixed that by reading the deep-link id ONCE; the #8354 page rewrite regressed it by reading the live searchParams every render, so the prop flips mid-session and re-fires the child's deep-link effect exactly as the modal closes. Frozen at mount again. Also tightens i18nUiCoverage 75.5 -> 99, which the ratchet demanded under --require-tighten: the metric genuinely improved as the async translation workflow paid off the debt that the v3.8.39/.44/.47 rebaselines had been recording. The collector subtracts placeholders, so this release's 317 __MISSING__ markers are already netted out of the 99. Two UI files still fail locally under 20-worker concurrency (combos-page-smoke, evals-tab-smoke) — cold-import flakes that pass isolated and with a larger timeout.
469 lines
16 KiB
TypeScript
469 lines
16 KiB
TypeScript
// @vitest-environment jsdom
|
|
import React from "react";
|
|
import { act } from "react";
|
|
import { createRoot } from "react-dom/client";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { EXPECTED_CODE_COUNT } from "@/shared/schemas/cliCatalog";
|
|
import type { ToolBatchStatusMap } from "@/shared/types/cliBatchStatus";
|
|
|
|
// ── Mocks ─────────────────────────────────────────────────────────────────────
|
|
|
|
vi.mock("next/link", () => ({
|
|
default: ({
|
|
href,
|
|
children,
|
|
...props
|
|
}: React.AnchorHTMLAttributes<HTMLAnchorElement> & { href: string }) => (
|
|
<a href={href} {...props}>
|
|
{children}
|
|
</a>
|
|
),
|
|
}));
|
|
|
|
// next-intl: no local mock — falls through to the real-EN-text default mock
|
|
// registered in tests/_setup/vitestUiPolyfills.ts (backed by src/i18n/messages/en.json
|
|
// via next-intl's own createTranslator). The previous local mock rendered raw
|
|
// "namespace.key" strings, which no longer matches most assertions below (they check
|
|
// literal English copy such as "Claude Code profiles").
|
|
|
|
// Mock CLI components so tests don't pull in their heavy dependencies
|
|
vi.mock("@/shared/components/cli", () => ({
|
|
CliToolCard: ({
|
|
tool,
|
|
detailHref,
|
|
}: {
|
|
tool: { name: string };
|
|
batchStatus: unknown;
|
|
detailHref: string;
|
|
hasActiveProviders: boolean;
|
|
}) => (
|
|
<div data-testid="cli-tool-card" data-href={detailHref}>
|
|
{tool.name}
|
|
</div>
|
|
),
|
|
CliConceptCard: ({ currentType }: { currentType: string }) => (
|
|
<div data-testid="cli-concept-card" data-type={currentType} />
|
|
),
|
|
CliComparisonCard: ({ currentType }: { currentType: string }) => (
|
|
<div data-testid="cli-comparison-card" data-type={currentType} />
|
|
),
|
|
}));
|
|
|
|
// Mock shared components to avoid CSS/animation deps
|
|
vi.mock("@/shared/components", () => ({
|
|
Button: ({
|
|
children,
|
|
onClick,
|
|
}: {
|
|
children: React.ReactNode;
|
|
onClick?: () => void;
|
|
[key: string]: unknown;
|
|
}) => (
|
|
<button data-testid="button" onClick={onClick}>
|
|
{children}
|
|
</button>
|
|
),
|
|
CardSkeleton: () => <div data-testid="card-skeleton" />,
|
|
Input: ({ placeholder, value, onChange }: React.InputHTMLAttributes<HTMLInputElement>) => (
|
|
<input data-testid="search-input" placeholder={placeholder} value={value} onChange={onChange} />
|
|
),
|
|
Toggle: ({
|
|
checked = false,
|
|
disabled = false,
|
|
label,
|
|
description,
|
|
onChange,
|
|
}: {
|
|
checked?: boolean;
|
|
disabled?: boolean;
|
|
label?: string;
|
|
description?: string;
|
|
onChange?: (checked: boolean) => void;
|
|
}) => (
|
|
<div data-testid="toggle-row">
|
|
<button
|
|
type="button"
|
|
role="switch"
|
|
aria-checked={checked}
|
|
aria-label={label}
|
|
disabled={disabled}
|
|
onClick={() => onChange?.(!checked)}
|
|
>
|
|
{label}
|
|
</button>
|
|
{description ? <span>{description}</span> : null}
|
|
</div>
|
|
),
|
|
}));
|
|
|
|
// ── useToolBatchStatuses mock ─────────────────────────────────────────────────
|
|
|
|
const mockRefetch = vi.fn();
|
|
let mockStatusesReturnValue: {
|
|
statuses: ToolBatchStatusMap | null;
|
|
loading: boolean;
|
|
error: string | null;
|
|
refetch: () => void;
|
|
} = {
|
|
statuses: null,
|
|
loading: false,
|
|
error: null,
|
|
refetch: mockRefetch,
|
|
};
|
|
|
|
vi.mock("@/shared/hooks/cli/useToolBatchStatuses", () => ({
|
|
useToolBatchStatuses: () => mockStatusesReturnValue,
|
|
}));
|
|
|
|
// ── fetch mock ────────────────────────────────────────────────────────────────
|
|
|
|
let mockFetchResponse: { connections?: unknown[] } = { connections: [{ isActive: true }] };
|
|
let mockFeatureFlagsResponse = {
|
|
flags: [
|
|
{ key: "OMNIROUTE_AUTO_SYNC_CODEX_PROFILES", effectiveValue: "false" },
|
|
{ key: "OMNIROUTE_AUTO_SYNC_CLAUDE_PROFILES", effectiveValue: "false" },
|
|
],
|
|
};
|
|
|
|
globalThis.fetch = vi.fn().mockImplementation((url: string, init?: RequestInit) => {
|
|
if (typeof url === "string" && url.includes("/api/providers")) {
|
|
return Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve(mockFetchResponse),
|
|
});
|
|
}
|
|
if (typeof url === "string" && url.includes("/api/settings/feature-flags")) {
|
|
if (init?.method === "PUT") {
|
|
return Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve({}),
|
|
});
|
|
}
|
|
return Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve(mockFeatureFlagsResponse),
|
|
});
|
|
}
|
|
return Promise.resolve({ ok: false, json: () => Promise.resolve({}) });
|
|
}) as typeof fetch;
|
|
|
|
// ── Import after mocks ────────────────────────────────────────────────────────
|
|
|
|
const { default: CliCodePageClient } =
|
|
await import("@/app/(dashboard)/dashboard/cli-code/CliCodePageClient");
|
|
|
|
// ── Helpers ───────────────────────────────────────────────────────────────────
|
|
|
|
const containers: HTMLElement[] = [];
|
|
let roots: ReturnType<typeof createRoot>[] = [];
|
|
|
|
async function renderPage(props: { machineId?: string } = {}): Promise<HTMLElement> {
|
|
const container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
containers.push(container);
|
|
|
|
const root = createRoot(container);
|
|
roots.push(root);
|
|
|
|
await act(async () => {
|
|
root.render(<CliCodePageClient machineId={props.machineId ?? "test-machine"} />);
|
|
});
|
|
|
|
// Let any pending microtasks (fetch promises) flush
|
|
await flushPromises();
|
|
|
|
return container;
|
|
}
|
|
|
|
async function flushPromises() {
|
|
await act(async () => {
|
|
await Promise.resolve();
|
|
});
|
|
}
|
|
|
|
// ── Lifecycle ─────────────────────────────────────────────────────────────────
|
|
|
|
beforeEach(() => {
|
|
(
|
|
globalThis as typeof globalThis & { IS_REACT_ACT_ENVIRONMENT?: boolean }
|
|
).IS_REACT_ACT_ENVIRONMENT = true;
|
|
vi.clearAllMocks();
|
|
mockRefetch.mockReset();
|
|
|
|
// Reset defaults
|
|
mockStatusesReturnValue = {
|
|
statuses: null,
|
|
loading: false,
|
|
error: null,
|
|
refetch: mockRefetch,
|
|
};
|
|
mockFetchResponse = { connections: [{ isActive: true }] };
|
|
mockFeatureFlagsResponse = {
|
|
flags: [
|
|
{ key: "OMNIROUTE_AUTO_SYNC_CODEX_PROFILES", effectiveValue: "false" },
|
|
{ key: "OMNIROUTE_AUTO_SYNC_CLAUDE_PROFILES", effectiveValue: "false" },
|
|
],
|
|
};
|
|
|
|
globalThis.fetch = vi.fn().mockImplementation((url: string, init?: RequestInit) => {
|
|
if (typeof url === "string" && url.includes("/api/providers")) {
|
|
return Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve(mockFetchResponse),
|
|
});
|
|
}
|
|
if (typeof url === "string" && url.includes("/api/settings/feature-flags")) {
|
|
if (init?.method === "PUT") {
|
|
return Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve({}),
|
|
});
|
|
}
|
|
return Promise.resolve({
|
|
ok: true,
|
|
json: () => Promise.resolve(mockFeatureFlagsResponse),
|
|
});
|
|
}
|
|
return Promise.resolve({ ok: false, json: () => Promise.resolve({}) });
|
|
}) as typeof fetch;
|
|
});
|
|
|
|
afterEach(() => {
|
|
while (roots.length > 0) {
|
|
const root = roots.pop();
|
|
if (root) act(() => root.unmount());
|
|
}
|
|
while (containers.length > 0) {
|
|
containers.pop()?.remove();
|
|
}
|
|
document.body.innerHTML = "";
|
|
});
|
|
|
|
// ── Tests ─────────────────────────────────────────────────────────────────────
|
|
|
|
describe("CliCodePageClient", () => {
|
|
it("1. render smoke: page renders without crash with active providers", async () => {
|
|
const container = await renderPage();
|
|
expect(container.innerHTML).toBeTruthy();
|
|
// Concept + comparison cards present
|
|
expect(container.querySelector('[data-testid="cli-concept-card"]')).not.toBeNull();
|
|
expect(container.querySelector('[data-testid="cli-comparison-card"]')).not.toBeNull();
|
|
});
|
|
|
|
it("2. renders every code tool card when catalogue is OK", async () => {
|
|
const container = await renderPage();
|
|
const cards = container.querySelectorAll('[data-testid="cli-tool-card"]');
|
|
expect(cards.length).toBe(EXPECTED_CODE_COUNT);
|
|
});
|
|
|
|
it("2b. renders CLI profile auto-sync toggles from feature flags", async () => {
|
|
mockFeatureFlagsResponse = {
|
|
flags: [
|
|
{ key: "OMNIROUTE_AUTO_SYNC_CODEX_PROFILES", effectiveValue: "true" },
|
|
{ key: "OMNIROUTE_AUTO_SYNC_CLAUDE_PROFILES", effectiveValue: "false" },
|
|
],
|
|
};
|
|
|
|
const container = await renderPage();
|
|
|
|
expect(container.textContent).toContain("CLI profile auto-sync");
|
|
expect(container.textContent).toContain("Codex profiles");
|
|
expect(container.textContent).toContain("Claude Code profiles");
|
|
expect(container.textContent).not.toContain("HTTP");
|
|
|
|
const codexToggle = container.querySelector(
|
|
'button[role="switch"][aria-label="Codex profiles"]'
|
|
);
|
|
const claudeToggle = container.querySelector(
|
|
'button[role="switch"][aria-label="Claude Code profiles"]'
|
|
);
|
|
|
|
expect(codexToggle?.getAttribute("aria-checked")).toBe("true");
|
|
expect(claudeToggle?.getAttribute("aria-checked")).toBe("false");
|
|
expect(globalThis.fetch).toHaveBeenCalledWith("/api/settings/feature-flags");
|
|
});
|
|
|
|
it("2c. persists CLI profile auto-sync toggle changes", async () => {
|
|
const container = await renderPage();
|
|
const codexToggle = container.querySelector(
|
|
'button[role="switch"][aria-label="Codex profiles"]'
|
|
) as HTMLButtonElement;
|
|
|
|
expect(codexToggle).not.toBeNull();
|
|
|
|
await act(async () => {
|
|
codexToggle.click();
|
|
await Promise.resolve();
|
|
});
|
|
|
|
expect(globalThis.fetch).toHaveBeenCalledWith("/api/settings/feature-flags", {
|
|
method: "PUT",
|
|
headers: { "Content-Type": "application/json" },
|
|
body: JSON.stringify({
|
|
key: "OMNIROUTE_AUTO_SYNC_CODEX_PROFILES",
|
|
value: "true",
|
|
}),
|
|
});
|
|
expect(codexToggle.getAttribute("aria-checked")).toBe("true");
|
|
});
|
|
|
|
it("3. search filter: typing 'claude' shows only 1 card", async () => {
|
|
const container = await renderPage();
|
|
|
|
// All code tools initially visible
|
|
expect(container.querySelectorAll('[data-testid="cli-tool-card"]').length).toBe(
|
|
EXPECTED_CODE_COUNT
|
|
);
|
|
|
|
const input = container.querySelector('[data-testid="search-input"]') as HTMLInputElement;
|
|
expect(input).not.toBeNull();
|
|
|
|
await act(async () => {
|
|
input.value = "claude";
|
|
input.dispatchEvent(new Event("input", { bubbles: true }));
|
|
// Simulate onChange
|
|
const syntheticEvent = {
|
|
target: { value: "claude" },
|
|
} as React.ChangeEvent<HTMLInputElement>;
|
|
// Find and call the onChange directly
|
|
const reactProps = Object.keys(input).find((k) => k.startsWith("__reactFiber"));
|
|
if (!reactProps) {
|
|
// Fallback: change event
|
|
Object.defineProperty(input, "value", { value: "claude", writable: true });
|
|
input.dispatchEvent(
|
|
Object.assign(new Event("change", { bubbles: true }), {
|
|
target: input,
|
|
})
|
|
);
|
|
}
|
|
void syntheticEvent;
|
|
});
|
|
|
|
// Re-render with search set via React state
|
|
// Since we can't easily trigger React onChange from jsdom, test the filtering logic indirectly
|
|
// by re-rendering with the search component directly
|
|
const root2 = roots[roots.length - 1];
|
|
await act(async () => {
|
|
// Reset and re-render a fresh instance to test filter results
|
|
root2.render(
|
|
<TestWrapper search="claude">
|
|
<CliCodePageClient machineId="test" />
|
|
</TestWrapper>
|
|
);
|
|
});
|
|
|
|
// We can verify with a simpler approach: check the card count remains non-zero (no crash)
|
|
expect(container.querySelectorAll('[data-testid="cli-tool-card"]').length).toBeGreaterThan(0);
|
|
});
|
|
|
|
it("3b. search filter with state update: typing filters cards", async () => {
|
|
const container = await renderPage();
|
|
const input = container.querySelector('[data-testid="search-input"]') as HTMLInputElement;
|
|
|
|
await act(async () => {
|
|
// Simulate React change event
|
|
const nativeInputValueSetter = Object.getOwnPropertyDescriptor(
|
|
window.HTMLInputElement.prototype,
|
|
"value"
|
|
)?.set;
|
|
nativeInputValueSetter?.call(input, "claude code");
|
|
input.dispatchEvent(new Event("change", { bubbles: true }));
|
|
});
|
|
|
|
const cards = container.querySelectorAll('[data-testid="cli-tool-card"]');
|
|
// After filtering for "claude code", only Claude Code CLI should match
|
|
expect(cards.length).toBeLessThan(EXPECTED_CODE_COUNT);
|
|
expect(cards.length).toBeGreaterThan(0);
|
|
// The visible card should contain "Claude Code"
|
|
expect(container.textContent).toContain("Claude Code");
|
|
});
|
|
|
|
it("4. detection filter: shows skeletons when loading", async () => {
|
|
mockStatusesReturnValue = { statuses: null, loading: true, error: null, refetch: mockRefetch };
|
|
|
|
const container = await renderPage();
|
|
const skeletons = container.querySelectorAll('[data-testid="card-skeleton"]');
|
|
expect(skeletons.length).toBe(6);
|
|
});
|
|
|
|
it("5. empty state: no active providers → amber banner with link to /dashboard/providers", async () => {
|
|
mockFetchResponse = { connections: [] };
|
|
|
|
const container = await renderPage();
|
|
|
|
// Wait for providers fetch
|
|
await act(async () => {
|
|
await Promise.resolve();
|
|
});
|
|
|
|
// The banner should appear (providers loading done, hasActiveProviders = false)
|
|
const providerLink = container.querySelector('a[href="/dashboard/providers"]');
|
|
expect(providerLink).not.toBeNull();
|
|
// Banner text (cliCommon.detail.noActiveProviders in src/i18n/messages/en.json)
|
|
expect(container.textContent).toContain("No active providers");
|
|
});
|
|
|
|
it("6. CliConceptCard rendered at top with currentType='code'", async () => {
|
|
const container = await renderPage();
|
|
const conceptCard = container.querySelector('[data-testid="cli-concept-card"]');
|
|
expect(conceptCard).not.toBeNull();
|
|
expect(conceptCard?.getAttribute("data-type")).toBe("code");
|
|
});
|
|
|
|
it("7. CliComparisonCard rendered with currentType='code'", async () => {
|
|
const container = await renderPage();
|
|
const comparisonCard = container.querySelector('[data-testid="cli-comparison-card"]');
|
|
expect(comparisonCard).not.toBeNull();
|
|
expect(comparisonCard?.getAttribute("data-type")).toBe("code");
|
|
});
|
|
|
|
it("8. refresh button click calls refetch()", async () => {
|
|
const container = await renderPage();
|
|
const refreshBtn = container.querySelector('[data-testid="button"]') as HTMLButtonElement;
|
|
expect(refreshBtn).not.toBeNull();
|
|
|
|
await act(async () => {
|
|
refreshBtn.click();
|
|
});
|
|
|
|
expect(mockRefetch).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("9. detailHref contains /dashboard/cli-code/<id> for each tool card", async () => {
|
|
const container = await renderPage();
|
|
const cards = container.querySelectorAll('[data-testid="cli-tool-card"]');
|
|
cards.forEach((card) => {
|
|
const href = card.getAttribute("data-href") ?? "";
|
|
expect(href).toMatch(/^\/dashboard\/cli-code\/.+/);
|
|
});
|
|
});
|
|
|
|
it("10. skeletons shown when providersLoading is true (initial render)", async () => {
|
|
mockStatusesReturnValue = { statuses: null, loading: true, error: null, refetch: mockRefetch };
|
|
|
|
// Delay the fetch so providers loading is true on initial render
|
|
const slowFetch = vi.fn().mockImplementation(() => new Promise(() => {})) as typeof fetch;
|
|
globalThis.fetch = slowFetch;
|
|
|
|
const container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
containers.push(container);
|
|
|
|
const root = createRoot(container);
|
|
roots.push(root);
|
|
|
|
// Render without awaiting fetch resolution
|
|
act(() => {
|
|
root.render(<CliCodePageClient machineId="test" />);
|
|
});
|
|
|
|
const skeletons = container.querySelectorAll('[data-testid="card-skeleton"]');
|
|
expect(skeletons.length).toBe(6);
|
|
});
|
|
});
|
|
|
|
// Helper wrapper (not exported) — needed only for test 3 internal use
|
|
function TestWrapper({ children }: { children: React.ReactNode; search?: string }) {
|
|
return <>{children}</>;
|
|
}
|