mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
121 lines
3.8 KiB
TypeScript
121 lines
3.8 KiB
TypeScript
// #8406: devin-cli ACP wire-format protocol fixes
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { writeFileSync } from "node:fs";
|
|
|
|
const mod = await import("../../open-sse/executors/devin-cli.ts");
|
|
|
|
type AcpFrame = {
|
|
method?: string;
|
|
params?: Record<string, unknown>;
|
|
};
|
|
|
|
test("#8406: DevinCliExecutor emits correct ACP wire-format frames and handles agent_message_chunk", async () => {
|
|
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "devin-acp-test-"));
|
|
const framesFile = path.join(tmpDir, "received_frames.json");
|
|
const scriptFile = path.join(tmpDir, "mock-devin");
|
|
|
|
const scriptContent = `#!/usr/bin/env node
|
|
const fs = require('fs');
|
|
const readline = require('readline');
|
|
|
|
const frames = [];
|
|
const rl = readline.createInterface({ input: process.stdin });
|
|
|
|
rl.on('line', (line) => {
|
|
if (!line.trim()) return;
|
|
let msg;
|
|
try { msg = JSON.parse(line); } catch (e) { return; }
|
|
frames.push(msg);
|
|
fs.writeFileSync(${JSON.stringify(framesFile)}, JSON.stringify(frames, null, 2));
|
|
|
|
if (msg.method === 'initialize') {
|
|
process.stdout.write(JSON.stringify({ jsonrpc: '2.0', result: {}, id: msg.id }) + '\\n');
|
|
} else if (msg.method === 'session/new') {
|
|
process.stdout.write(JSON.stringify({ jsonrpc: '2.0', result: { sessionId: 'sess-8406' }, id: msg.id }) + '\\n');
|
|
} else if (msg.method === 'session/prompt') {
|
|
const updateMsg = {
|
|
jsonrpc: '2.0',
|
|
method: 'session/update',
|
|
params: {
|
|
update: {
|
|
sessionUpdate: 'agent_message_chunk',
|
|
content: { type: 'text', text: 'Hello ACP 8406' }
|
|
}
|
|
}
|
|
};
|
|
process.stdout.write(JSON.stringify(updateMsg) + '\\n');
|
|
const resultMsg = {
|
|
jsonrpc: '2.0',
|
|
result: { stopReason: 'end_turn' },
|
|
id: msg.id
|
|
};
|
|
process.stdout.write(JSON.stringify(resultMsg) + '\\n');
|
|
}
|
|
});
|
|
`;
|
|
|
|
writeFileSync(scriptFile, scriptContent, { mode: 0o755 });
|
|
|
|
const oldBin = process.env.CLI_DEVIN_BIN;
|
|
process.env.CLI_DEVIN_BIN = scriptFile;
|
|
|
|
try {
|
|
const executor = new mod.DevinCliExecutor();
|
|
const res = await executor.execute({
|
|
model: "swe-1-6-fast",
|
|
body: { messages: [{ role: "user", content: "hi" }] },
|
|
stream: true,
|
|
credentials: { apiKey: "test-key" },
|
|
});
|
|
|
|
const reader = res.response.body!.getReader();
|
|
const decoder = new TextDecoder();
|
|
let sseOutput = "";
|
|
|
|
while (true) {
|
|
const { done, value } = await reader.read();
|
|
if (done) break;
|
|
sseOutput += decoder.decode(value, { stream: true });
|
|
}
|
|
|
|
const receivedFrames: AcpFrame[] = JSON.parse(fs.readFileSync(framesFile, "utf-8"));
|
|
|
|
const newFrame = receivedFrames.find((f) => f.method === "session/new");
|
|
assert.ok(newFrame, "session/new frame must be sent");
|
|
assert.ok(
|
|
Array.isArray(newFrame.params.mcpServers),
|
|
"session/new must include mcpServers array"
|
|
);
|
|
|
|
const promptFrame = receivedFrames.find((f) => f.method === "session/prompt");
|
|
assert.ok(promptFrame, "session/prompt frame must be sent");
|
|
assert.ok(
|
|
Array.isArray(promptFrame.params.prompt),
|
|
"session/prompt must name the field prompt"
|
|
);
|
|
assert.equal(
|
|
promptFrame.params.content,
|
|
undefined,
|
|
"session/prompt must not use content field"
|
|
);
|
|
|
|
assert.match(
|
|
sseOutput,
|
|
/Hello ACP 8406/,
|
|
"SSE output must contain chunk text from agent_message_chunk"
|
|
);
|
|
assert.match(sseOutput, /data: \[DONE\]/, "SSE output must terminate with [DONE]");
|
|
} finally {
|
|
if (oldBin !== undefined) {
|
|
process.env.CLI_DEVIN_BIN = oldBin;
|
|
} else {
|
|
delete process.env.CLI_DEVIN_BIN;
|
|
}
|
|
fs.rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|