Files
OmniRoute/tests/unit/cli-catalog-counts.test.ts
Hamsa_M 1bc6da5318 feat(cli): add CLI tools for pi, omp, letta, codewhale and jcode (#6318)
* feat(cli): add CLI tools for pi, omp, letta, codewhale and jcode

* fix(build): resolve CI build and lint errors

* fix(cli): resolve merge conflicts, add tests, align error handling for cli-additions

Resolve duplicate codewhale key from base merge, add unit/integration
tests for omp/letta settings routes and the omp DB module, and align
omp-settings/letta-settings error handling with sanitizeErrorMessage()
+ the pattern used by sibling jcode/pi/codewhale routes in this PR.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

* chore(quality): correct cliRuntime.ts file-size baseline to actual post-merge line count

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

* fix(changelog): re-restore #6318 bullet after release sync

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

* fix(merge): restore #6126 clinepass files reverted by release auto-resolve + baseline re-merge

The release sync's auto-resolve reverted sibling PR #6126's clinepass work
(registry, catalog, oauth constants, clineAuth.ts, token-refresh case, tests)
and the file-size baseline — all outside this PR's scope. Restored to the
release versions, re-applied only this PR's own baseline entries, restored the
#6126 CHANGELOG bullet (re-inserting only this PR's own).

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

* fix(db): re-export db/omp from localDb (check:db-rules #2)

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

* fix(db): keep localDb.ts at the 800-line cap after the omp re-export

Folded the MemoryVecMeta type re-export into the memoryVec named-export block
(inline 'type' specifier) so adding the db/omp line stays within the new-file
cap.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

* fix(cli): reduce #6318 scope to omp + letta (pi/codewhale/jcode already shipped)

pi, codewhale, and jcode landed via a separate PR before this one was
reconciled — re-adding parallel versions of their catalog entries, routes,
dashboard card, and i18n strings would have been a straight regression
(duplicate "pi" key silently shadowing the release's own entry, orphaned
JcodeToolCard/BaseUrlSelect/ApiKeySelect/cliEndpointMatch UI files with no
release-side wiring, and unrelated formatting/refactor drift in
codewhale-settings/pi-settings/config-generator/routeGuard picked up along
the way).

This PR now ships only the two tools that are genuinely new: omp (Oh My Pi)
and letta. Both settings routes shell out to `which omp`/`which letta` to
detect the local install, so they're loopback-gated in
LOCAL_ONLY_API_PREFIXES (Hard Rules #15/#17) in addition to the shared
requireCliToolsAuth() guard every cli-tools route requires
(tests/unit/cli-tools-auth-hardening.test.ts) — neither route had the guard
wired in yet. cli-catalog-counts.test.ts is updated to the real cardinality
(8 agent entries / 32 total, since omp+letta are both category "agent";
pi/codewhale/jcode were always category "code" and are unaffected). The
integration tests for omp/letta now pass a Request object to GET/DELETE and
assert the 401-when-auth-required path, matching the pattern already used by
the codewhale/jcode sibling routes. complexity-baseline.json is back to the
release's 2053 (the #6318 rebaseline note is gone — dropping the duplicate
JcodeToolCard.tsx/BaseUrlSelect.tsx removed the violations it was covering);
file-size-baseline.json's cliTools.ts entry shrank 955->915 to match the
smaller real file. CHANGELOG bullet rewritten to describe only omp+letta,
with a note on why pi/codewhale/jcode aren't part of this PR; also restores
the Kiro External IdP bullet that a prior merge auto-resolve had dropped
from the living section.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

* test(cli-tools): align cli-tools-schema registry count with omp+letta (30→32)

Second exact-count guard missed in the scope-reduction pass; same legitimate
alignment as cli-catalog-counts.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

* fix(cli-tools): omp entry needs docsUrl (CliCatalogEntrySchema requires it)

https://github.com/can1357/oh-my-pi — verified official repo.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

* chore(quality): cliTools.ts frozen 915→916 (+1 omp docsUrl line, own growth)

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

* chore(changelog): restore base + re-insert #6318 bullet after release sync

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

* chore(sync): merge release tip + restore own CHANGELOG bullet

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

---------

Co-authored-by: hamsa0x7 <hamsa0x7@users.noreply.github.com>
Co-authored-by: Diego Rodrigues de Sa e Souza <diegosouza.pw@gmail.com>
Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
2026-07-10 01:27:52 -03:00

120 lines
3.6 KiB
TypeScript

/**
* F1: cli-catalog-counts.test.ts
* Assert catalog cardinality per plan 14 D15 / §3.1-§3.2.
*/
import test from "node:test";
import assert from "node:assert/strict";
const { CLI_TOOLS } = await import("../../src/shared/constants/cliTools.ts");
const { EXPECTED_CODE_COUNT, EXPECTED_AGENT_COUNT } =
await import("../../src/shared/schemas/cliCatalog.ts");
const all = Object.values(CLI_TOOLS);
const codeAll = all.filter((t) => t.category === "code");
const agentAll = all.filter((t) => t.category === "agent");
const codeVisible = codeAll.filter((t) => t.baseUrlSupport !== "none");
test(`CLI_TOOLS has exactly ${EXPECTED_CODE_COUNT} code entries with baseUrlSupport !== 'none'`, () => {
assert.equal(
codeVisible.length,
EXPECTED_CODE_COUNT,
`Expected ${EXPECTED_CODE_COUNT} visible code entries, got ${codeVisible.length}: ${codeVisible.map((t) => t.id).join(", ")}`
);
});
test(`CLI_TOOLS has exactly ${EXPECTED_AGENT_COUNT} agent entries`, () => {
assert.equal(
agentAll.length,
EXPECTED_AGENT_COUNT,
`Expected ${EXPECTED_AGENT_COUNT} agent entries, got ${agentAll.length}: ${agentAll.map((t) => t.id).join(", ")}`
);
});
test("CLI_TOOLS total code entries (including none) equals 24 (20 visible + 4 none)", () => {
// code-none entries: antigravity, kiro, cursor (app), hermes (simple guide)
const codeNone = codeAll.filter((t) => t.baseUrlSupport === "none");
assert.equal(
codeNone.length,
4,
`Expected 4 code entries with baseUrlSupport='none', got ${codeNone.length}: ${codeNone.map((t) => t.id).join(", ")}`
);
assert.equal(codeAll.length, 24, `Expected 24 total code entries, got ${codeAll.length}`);
});
test("CLI_TOOLS total (code + agent) = 32", () => {
assert.equal(all.length, 32, `Expected 32 total entries, got ${all.length}`);
});
test("All code-none entries have configType mitm OR are legacy excluded entries", () => {
const codeNone = codeAll.filter((t) => t.baseUrlSupport === "none");
const allowedIds = new Set(["antigravity", "kiro", "cursor", "hermes"]);
for (const entry of codeNone) {
assert.ok(
allowedIds.has(entry.id),
`Unexpected code entry with baseUrlSupport='none': ${entry.id}`
);
}
});
test("All agent entries have baseUrlSupport 'full' or 'partial' (no agent is 'none')", () => {
for (const entry of agentAll) {
assert.notEqual(
entry.baseUrlSupport,
"none",
`Agent entry '${entry.id}' has unexpected baseUrlSupport='none'`
);
}
});
test("The 20 visible code entries match D15 list exactly (+ crush + codewhale)", () => {
const d15List = new Set([
"claude",
"codex",
"cline",
"kilo",
"roo",
"continue",
"qwen",
"aider",
"forge",
"jcode",
"deepseek-tui",
"codewhale",
"opencode",
"droid",
"copilot",
"cursor-cli",
"smelt",
"pi",
"custom",
"crush",
]);
const visibleIds = new Set(codeVisible.map((t) => t.id));
for (const id of d15List) {
assert.ok(visibleIds.has(id), `D15 entry '${id}' not found in visible code list`);
}
for (const id of visibleIds) {
assert.ok(d15List.has(id), `Visible code entry '${id}' not in D15 list`);
}
});
test("The 8 agent entries match D15 list exactly (+ omp + letta, #6318)", () => {
const d15Agents = new Set([
"hermes-agent",
"openclaw",
"goose",
"interpreter",
"warp",
"agent-deck",
"omp",
"letta",
]);
const agentIds = new Set(agentAll.map((t) => t.id));
for (const id of d15Agents) {
assert.ok(agentIds.has(id), `D15 agent '${id}' not found in agent entries`);
}
for (const id of agentIds) {
assert.ok(d15Agents.has(id), `Agent entry '${id}' not in D15 agent list`);
}
});