mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-12 02:02:13 +03:00
904e8af09a
The bundled @omniroute/opencode-plugin registers its provider under 'opencode-omniroute' (the 'opencode-' prefix is required by OpenCode >=1.17.8's native-adapter gate on model providerID). But the CLI instructed 'opencode auth login --provider omniroute' — the unprefixed id — so OpenCode reported 'Unknown provider "omniroute"' because it resolves --provider against the exact provider id the plugin registered. Add resolveOpenCodeAuthProviderId() helper that idempotently adds the 'opencode-' prefix when absent, and use it everywhere the CLI builds or prints the --provider argument: resolveOpenCodeAuthSpawn args, runOpenCodeAuth ENOENT message, and runSetupOpenCodeCommand 'Run manually'/'Next step' messages. Update the plugin README and test assertions to match. Co-authored-by: diegosouzapw <diegosouzapw@users.noreply.github.com>
64 lines
2.7 KiB
JavaScript
64 lines
2.7 KiB
JavaScript
// Regression test for #7913: `omniroute setup opencode --auth` spawns the
|
|
// `opencode.cmd` shim on win32. Since Node's CVE-2024-27980 hardening,
|
|
// spawning a `.cmd`/`.bat` shim with `shell:false` throws EINVAL — the same
|
|
// class already fixed for codex (bin/cli/commands/launch-codex.mjs,
|
|
// crediting #6263) and qodercli/Auggie (#6263/#6304). This callsite was
|
|
// missed; `resolveOpenCodeAuthSpawn` must use `shell: isWin`.
|
|
//
|
|
// Tested through the pure `resolveOpenCodeAuthSpawn(providerId, platform)`
|
|
// resolver (no child_process mocking, no process.platform mutation — both of
|
|
// which required an unavailable --experimental-test-module-mocks flag in CI).
|
|
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
import {
|
|
resolveOpenCodeAuthSpawn,
|
|
resolveOpenCodeAuthProviderId,
|
|
} from "../../bin/cli/commands/setup-open-code.mjs";
|
|
|
|
test("resolveOpenCodeAuthSpawn: win32 spawns opencode.cmd with shell:true (repro #7913)", () => {
|
|
const spawn = resolveOpenCodeAuthSpawn("omniroute", "win32");
|
|
assert.equal(spawn.command, "opencode.cmd");
|
|
assert.equal(
|
|
spawn.options.shell,
|
|
true,
|
|
`expected shell:true on win32 (the EINVAL fix), got shell:${spawn.options.shell}`
|
|
);
|
|
assert.deepEqual(spawn.args, ["auth", "login", "--provider", "opencode-omniroute"]);
|
|
});
|
|
|
|
test("resolveOpenCodeAuthSpawn: linux/darwin spawn bare opencode with shell:false (no regression)", () => {
|
|
for (const platform of ["linux", "darwin"]) {
|
|
const spawn = resolveOpenCodeAuthSpawn("omniroute", platform);
|
|
assert.equal(spawn.command, "opencode", `command on ${platform}`);
|
|
assert.equal(
|
|
spawn.options.shell,
|
|
false,
|
|
`expected shell:false on ${platform}, got shell:${spawn.options.shell}`
|
|
);
|
|
}
|
|
});
|
|
|
|
test("resolveOpenCodeAuthSpawn: prefixes provider id for auth login (#8830)", () => {
|
|
const spawn = resolveOpenCodeAuthSpawn("anthropic", "linux");
|
|
assert.deepEqual(spawn.args, ["auth", "login", "--provider", "opencode-anthropic"]);
|
|
});
|
|
|
|
test("resolveOpenCodeAuthProviderId: adds opencode- prefix when absent (#8830)", () => {
|
|
assert.equal(resolveOpenCodeAuthProviderId("omniroute"), "opencode-omniroute");
|
|
assert.equal(resolveOpenCodeAuthProviderId("omniroute-preprod"), "opencode-omniroute-preprod");
|
|
assert.equal(resolveOpenCodeAuthProviderId("anthropic"), "opencode-anthropic");
|
|
});
|
|
|
|
test("resolveOpenCodeAuthProviderId: idempotent — passes through already-prefixed ids (#8830)", () => {
|
|
assert.equal(resolveOpenCodeAuthProviderId("opencode-omniroute"), "opencode-omniroute");
|
|
assert.equal(
|
|
resolveOpenCodeAuthProviderId("opencode-omniroute-preprod"),
|
|
"opencode-omniroute-preprod"
|
|
);
|
|
assert.equal(
|
|
resolveOpenCodeAuthProviderId("opencode-anthropic"),
|
|
"opencode-anthropic"
|
|
);
|
|
});
|