Files
OmniRoute/tests/unit/call-logs-correlation-substring.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

153 lines
4.8 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-cid-substr-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const callLogs = await import("../../src/lib/usage/callLogs.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
// Seed test data
function seedLogs() {
const db = core.getDbInstance();
const now = new Date().toISOString();
db.prepare(
`INSERT OR REPLACE INTO call_logs (id, timestamp, method, path, status, model, provider, account, duration, tokens_in, tokens_out, correlation_id)
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`
).run(
"log-1",
now,
"POST",
"/v1/chat/completions",
200,
"gpt-4",
"openai",
"acc1",
100,
10,
20,
"abc123-def456-ghi789"
);
db.prepare(
`INSERT OR REPLACE INTO call_logs (id, timestamp, method, path, status, model, provider, account, duration, tokens_in, tokens_out, correlation_id)
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`
).run(
"log-2",
now,
"POST",
"/v1/chat/completions",
200,
"claude-3",
"anthropic",
"acc2",
200,
15,
30,
"xyz999-uvw888-tsr777"
);
db.prepare(
`INSERT OR REPLACE INTO call_logs (id, timestamp, method, path, status, model, provider, account, duration, tokens_in, tokens_out, correlation_id)
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`
).run(
"log-3",
now,
"POST",
"/v1/chat/completions",
500,
"gpt-4",
"openai",
"acc1",
50,
0,
0,
null
);
}
// ── Exact match ───────────────────────────────────────────────────────────
test("correlationId exact match returns single entry", async () => {
seedLogs();
const results = await callLogs.getCallLogs({ correlationId: "abc123-def456-ghi789" });
assert.equal(results.length, 1);
assert.equal(results[0].correlationId, "abc123-def456-ghi789");
});
// ── Substring match ───────────────────────────────────────────────────────
test("correlationId substring match (prefix)", async () => {
seedLogs();
const results = await callLogs.getCallLogs({ correlationId: "abc123" });
assert.equal(results.length, 1);
assert.equal(results[0].id, "log-1");
});
test("correlationId substring match (middle)", async () => {
seedLogs();
const results = await callLogs.getCallLogs({ correlationId: "def456" });
assert.equal(results.length, 1);
assert.equal(results[0].id, "log-1");
});
test("correlationId substring match (suffix)", async () => {
seedLogs();
const results = await callLogs.getCallLogs({ correlationId: "ghi789" });
assert.equal(results.length, 1);
assert.equal(results[0].id, "log-1");
});
test("correlationId substring match returns multiple when shared", async () => {
const db = core.getDbInstance();
const now = new Date().toISOString();
// Add another log sharing a substring
db.prepare(
`INSERT OR REPLACE INTO call_logs (id, timestamp, method, path, status, model, provider, account, duration, tokens_in, tokens_out, correlation_id)
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`
).run(
"log-4",
now,
"POST",
"/v1/chat/completions",
200,
"gpt-4",
"openai",
"acc1",
100,
10,
20,
"abc123-RETRY-suffix"
);
const results = await callLogs.getCallLogs({ correlationId: "abc123" });
assert.equal(results.length, 2);
const ids = results.map((r: { id: string }) => r.id).sort();
assert.deepEqual(ids, ["log-1", "log-4"]);
});
// ── No match ──────────────────────────────────────────────────────────────
test("correlationId no match returns empty", async () => {
seedLogs();
const results = await callLogs.getCallLogs({ correlationId: "nonexistent" });
assert.equal(results.length, 0);
});
// ── Null/empty correlationId rows excluded ─────────────────────────────────
test("rows with null correlationId are excluded from substring search", async () => {
seedLogs();
// Search for a unique substring that only matches log-1
const results = await callLogs.getCallLogs({ correlationId: "ghi789" });
const ids = results.map((r: { id: string }) => r.id);
assert.ok(!ids.includes("log-3"), "null correlation_id rows must be excluded");
assert.equal(results.length, 1);
});