mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
149 lines
5.7 KiB
TypeScript
149 lines
5.7 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-model-lifecycle-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "model-lifecycle-test-secret";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const modelsDb = await import("../../src/lib/db/models.ts");
|
|
const apiKeysDb = await import("../../src/lib/db/apiKeys.ts");
|
|
const v1ModelsCatalog = await import("../../src/app/api/v1/models/catalog.ts");
|
|
const providerModelsRoute = await import("../../src/app/api/providers/[id]/models/route.ts");
|
|
const { handleChatCore } = await import("../../open-sse/handlers/chatCore.ts");
|
|
|
|
const originalFetch = globalThis.fetch;
|
|
|
|
async function resetStorage() {
|
|
globalThis.fetch = originalFetch;
|
|
core.resetDbInstance();
|
|
apiKeysDb.resetApiKeyState();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
v1ModelsCatalog.__resetCatalogBuilderRunsForTest();
|
|
}
|
|
|
|
async function seedOpenAiConnection() {
|
|
return providersDb.createProviderConnection({
|
|
provider: "openai",
|
|
authType: "apikey",
|
|
name: `openai-${Math.random().toString(16).slice(2, 8)}`,
|
|
apiKey: "sk-openai",
|
|
isActive: true,
|
|
testStatus: "active",
|
|
providerSpecificData: {},
|
|
});
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(() => {
|
|
globalThis.fetch = originalFetch;
|
|
core.resetDbInstance();
|
|
apiKeysDb.resetApiKeyState();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("chatCore rejects a shutdown OpenAI model before an upstream request", async () => {
|
|
const originalFetch = globalThis.fetch;
|
|
let upstreamCalls = 0;
|
|
globalThis.fetch = async () => {
|
|
upstreamCalls += 1;
|
|
return new Response("unexpected", { status: 200 });
|
|
};
|
|
|
|
try {
|
|
const body = {
|
|
model: "gpt-5.2-codex",
|
|
messages: [{ role: "user", content: "hello" }],
|
|
};
|
|
const result = await handleChatCore({
|
|
body: structuredClone(body),
|
|
modelInfo: {
|
|
provider: "openai",
|
|
model: "gpt-5.2-codex",
|
|
extendedContext: false,
|
|
},
|
|
credentials: { apiKey: "sk-test", providerSpecificData: {} },
|
|
log: { debug() {}, info() {}, warn() {}, error() {} },
|
|
clientRawRequest: {
|
|
endpoint: "/v1/chat/completions",
|
|
body: structuredClone(body),
|
|
headers: new Headers({ accept: "application/json" }),
|
|
},
|
|
userAgent: "model-lifecycle-test",
|
|
});
|
|
|
|
assert.equal(result.success, false);
|
|
assert.equal(result.status, 410);
|
|
assert.equal(result.errorCode, "model_shutdown");
|
|
assert.equal(upstreamCalls, 0);
|
|
|
|
const responseBody = await result.response.json();
|
|
assert.equal(responseBody.error.code, "model_shutdown");
|
|
assert.match(responseBody.error.message, /openai\/gpt-5\.2-codex/);
|
|
assert.match(responseBody.error.message, /openai\/gpt-5\.6-sol/);
|
|
} finally {
|
|
globalThis.fetch = originalFetch;
|
|
}
|
|
});
|
|
|
|
test("unified catalog suppresses stale OpenAI chat rows but retains typed media", async () => {
|
|
const connection = await seedOpenAiConnection();
|
|
await modelsDb.replaceSyncedAvailableModelsForConnection("openai", connection.id, [
|
|
{ id: "gpt-5.2-codex", name: "GPT-5.2 Codex", source: "imported" },
|
|
{ id: "gpt-image-2", name: "GPT Image 2", source: "imported" },
|
|
{ id: "sora-2-pro", name: "Sora 2 Pro", source: "imported" },
|
|
]);
|
|
await modelsDb.replaceCustomModels("openai", [
|
|
{ id: "sora-2", name: "Sora 2", source: "imported" },
|
|
]);
|
|
|
|
const response = await v1ModelsCatalog.getUnifiedModelsResponse(
|
|
new Request("http://localhost/api/v1/models")
|
|
);
|
|
const body = (await response.json()) as { data: Array<{ id: string; type?: string }> };
|
|
const ids = new Set(body.data.map((item) => item.id));
|
|
|
|
assert.equal(response.status, 200);
|
|
assert.equal(ids.has("openai/gpt-5.2-codex"), false);
|
|
assert.equal(ids.has("openai/sora-2"), false);
|
|
assert.equal(ids.has("openai/sora-2-pro"), false);
|
|
// Since #11919 (fixes #11829) an authoritative live catalog REPLACES the static
|
|
// registry: a static-only row like gpt-5.6-sol that the synced catalog does not
|
|
// list is suppressed instead of leaking into /v1/models. The lifecycle contract
|
|
// this file guards (#8627: stale chat rows suppressed, typed media retained)
|
|
// is unchanged — only the "static rows survive a sync" expectation moved.
|
|
assert.equal(ids.has("openai/gpt-5.6-sol"), false);
|
|
assert.equal(body.data.find((item) => item.id === "openai/gpt-image-2")?.type, "image");
|
|
});
|
|
|
|
test("chat-only provider catalog excludes OpenAI lifecycle and media models", async () => {
|
|
const connection = await seedOpenAiConnection();
|
|
await modelsDb.replaceSyncedAvailableModelsForConnection("openai", connection.id, [
|
|
{ id: "gpt-5.6-sol", name: "GPT-5.6 Sol", source: "imported" },
|
|
{ id: "gpt-5.2-codex", name: "GPT-5.2 Codex", source: "imported" },
|
|
{ id: "gpt-5.3-chat-latest", name: "GPT-5.3 Chat", source: "imported" },
|
|
{ id: "gpt-image-2", name: "GPT Image 2", source: "imported" },
|
|
{ id: "sora-2-pro", name: "Sora 2 Pro", source: "imported" },
|
|
]);
|
|
|
|
const response = await providerModelsRoute.GET(
|
|
new Request(`http://localhost/api/providers/${connection.id}/models?chatOnly=true`),
|
|
{ params: { id: connection.id } }
|
|
);
|
|
const body = (await response.json()) as { models: Array<{ id: string }> };
|
|
|
|
assert.equal(response.status, 200);
|
|
assert.deepEqual(
|
|
body.models.map((model) => model.id),
|
|
["gpt-5.6-sol"]
|
|
);
|
|
});
|