mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 19:02:17 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
70 lines
2.6 KiB
TypeScript
70 lines
2.6 KiB
TypeScript
/**
|
|
* Regression guard (PR #7046 / perf-api-pagination fallout): src/lib/db/proxies.ts
|
|
* `listProxies()` was changed to return `{ items, total }` for pagination, but
|
|
* validateProxyPool()'s DEFAULT (non-injected) implementation still did
|
|
* `const proxies = await listProxies(); for (const p of proxies) ...` — iterating
|
|
* the paginated envelope object instead of `.items` crashes at runtime
|
|
* ("proxies is not iterable"). src/app/api/settings/proxies/egress/route.ts calls
|
|
* validateProxyPool() with no deps, so this is the real, exercised production path.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-egress-default-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const proxiesDb = await import("../../src/lib/db/proxies.ts");
|
|
const egress = await import("../../src/lib/proxyEgress.ts");
|
|
const { validateProxyPool, _setEgressProbeForTests, clearEgressCache } = egress as unknown as {
|
|
validateProxyPool: (
|
|
deps?: unknown
|
|
) => Promise<Array<{ proxyId: string; alive: boolean; newStatus: string }>>;
|
|
_setEgressProbeForTests: (fn: unknown) => void;
|
|
clearEgressCache: () => void;
|
|
};
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
clearEgressCache();
|
|
});
|
|
|
|
test.after(() => {
|
|
_setEgressProbeForTests(null);
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("validateProxyPool() with no injected deps does not crash on the real listProxies() {items,total} shape", async () => {
|
|
await proxiesDb.createProxy({
|
|
name: "Default Path Proxy",
|
|
type: "http",
|
|
host: "default-path.local",
|
|
port: 8080,
|
|
});
|
|
|
|
_setEgressProbeForTests(async (proxyUrl: string | null) => ({
|
|
ip: proxyUrl ? "203.0.113.9" : null,
|
|
latencyMs: 3,
|
|
}));
|
|
|
|
const report = await validateProxyPool();
|
|
|
|
assert.equal(Array.isArray(report), true, "validateProxyPool must resolve to an array");
|
|
assert.equal(report.length, 1);
|
|
assert.equal(report[0].alive, true);
|
|
assert.equal(report[0].newStatus, "active");
|
|
|
|
const { items: proxies } = await proxiesDb.listProxies({ includeSecrets: false });
|
|
assert.equal(proxies[0].status, "active", "markStatus default path must persist via updateProxy");
|
|
});
|