MumuTW 5840d0961f fix(plugins): delete the generated host script synchronously so plugin loads stop leaking temp files (#8749) ...

* fix(plugins): delete the host script synchronously and stop two tests leaking child processes

Three related leaks in the plugin child-process lifecycle, found while tracing 27 node
processes on a developer machine.

1. loader.ts removed the generated omniroute-plugin-host-*.mjs with a fire-and-forget
   `rm(...).catch(() => {})`. That unlink loses the race against process exit: test:unit
   runs with --test-force-exit, which tears the process down before the promise settles,
   so every plugin load leaked one temp .mjs into TMPDIR. Measured at 6 files per
   full-suite run, 40 accumulated over a handful of local runs. rmSync closes the race;
   the throw stays swallowed because an exception raised from a child "exit" handler
   would take the server down, and a leftover temp script would not.

2. plugins-manager-lifecycle.test.ts "activates an installed plugin" called activate() --
   which spawns the plugin's child process -- but never deactivate(). deactivate() is the
   only path that reaches the loader's cleanup(), so the child outlived the test and its
   IPC channel kept the test process's event loop alive.

3. plugins-manager-restart-reload-7806.test.ts simulateRestart() deleted the entry from
   loadedPlugins without calling cleanup(), dropping the only handle that can kill child
   #1. The reload then spawned child #2, and the finally block's deactivate() could reach
   only child #2 -- one dangling child per test. A real restart takes the whole process
   tree down, so calling cleanup() here is both the faithful simulation and the fix.

Combined effect: a run without --test-force-exit deadlocks. The test process cannot exit
while its child holds the IPC channel open, and the child waits for messages that never
come. Observed as three plugin hosts alive for 4h51m under a runner that never finished.

Validation (Hard Rule #18, TDD): the new plugins-loader.test.ts case fails against the old
async unlink ("must delete the host script synchronously, not on a later tick") and passes
with rmSync. It redirects TMPDIR/TEMP/TMP to a private directory before counting, because
test:unit runs at --test-concurrency=20 and a concurrent file's host scripts would
otherwise land in the counted directory and flake the assertion.

After: 19/19 pass across the three files, 0 temp scripts created, 0 orphan processes.
tests/unit/build/** 334/334; typecheck:core and eslint clean.

* docs(changelog): add fragment for plugin host script sync delete

2026-07-27 17:25:38 -03:00

8.6 KiB

Raw Blame History

View Raw